Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCO-1215: add ManagedBootImagesAWS to Feature Gate #1945

Merged
merged 1 commit into from
Jul 9, 2024
Merged

MCO-1215: add ManagedBootImagesAWS to Feature Gate #1945

merged 1 commit into from
Jul 9, 2024

Conversation

CourtCourt521
Copy link
Contributor

This adds a feature gate for supporting boot image updates on the AWS platform

building off of

openshift/enhancements#1496

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 2, 2024 •
edited by openshift-ci bot
Loading

@CourtCourt521: This pull request references MCO-1215 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

This adds a feature gate for supporting boot image updates on the AWS platform

building off of

openshift/enhancements#1496

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 2, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 2, 2024

Hello @CourtCourt521! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 2, 2024
@openshift-ci openshift-ci bot requested review from deads2k and JoelSpeed July 2, 2024 19:10
@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CourtCourt521, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 01da8e8 and 2 for PR HEAD 36495ac in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 33ed71a and 1 for PR HEAD 36495ac in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c9a9194 and 0 for PR HEAD 36495ac in total

@openshift-ci-robot
Copy link

/hold

Revision 36495ac was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
@djoshy
Copy link
Contributor

djoshy commented Jul 8, 2024

/unhold

/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

@CourtCourt521: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 329ea37 into openshift:master Jul 9, 2024
18 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.17.0-202407090112.p0.g329ea37.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CourtCourt521 @openshift-ci-robot @JoelSpeed @djoshy @openshift-bot