Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] WRKLDS-1449: bump(k8s): update k8s.io/* dependencies to v1.31.0 #1983

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

[WIP] WRKLDS-1449: bump(k8s): update k8s.io/* dependencies to v1.31.0 #1983

wants to merge 17 commits into from

Conversation

atiratree
Copy link
Member

@atiratree atiratree commented Aug 1, 2024 •
edited
Loading

TODO:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 1, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 1, 2024 •
edited by openshift-ci bot
Loading

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.18" instead.

In response to this:

  • WIP: make update not passing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 1, 2024

Hello @atiratree! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 1, 2024
@openshift-ci openshift-ci bot requested review from deads2k and soltysh August 1, 2024 18:53
@atiratree atiratree mentioned this pull request Aug 2, 2024
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atiratree
Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 5, 2024 •
edited by openshift-ci bot
Loading

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.18" instead.

In response to this:

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@atiratree
Copy link
Member Author

The PR passes make update so we can use it as a dependency for now, but there are still TODOs which are mentioned in the description.

@atiratree
Copy link
Member Author

/test verify-client-go

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 5, 2024

@atiratree: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test build
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-hypershift
  • /test e2e-aws-ovn-techpreview
  • /test e2e-aws-serial
  • /test e2e-aws-serial-techpreview
  • /test e2e-upgrade
  • /test e2e-upgrade-minor
  • /test images
  • /test integration
  • /test unit
  • /test verify
  • /test verify-client-go
  • /test verify-crd-schema
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test e2e-azure
  • /test e2e-gcp
  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-api-master-build
  • pull-ci-openshift-api-master-e2e-aws-ovn
  • pull-ci-openshift-api-master-e2e-aws-ovn-hypershift
  • pull-ci-openshift-api-master-e2e-aws-ovn-techpreview
  • pull-ci-openshift-api-master-e2e-aws-serial
  • pull-ci-openshift-api-master-e2e-aws-serial-techpreview
  • pull-ci-openshift-api-master-e2e-azure
  • pull-ci-openshift-api-master-e2e-gcp
  • pull-ci-openshift-api-master-e2e-upgrade
  • pull-ci-openshift-api-master-e2e-upgrade-minor
  • pull-ci-openshift-api-master-images
  • pull-ci-openshift-api-master-integration
  • pull-ci-openshift-api-master-unit
  • pull-ci-openshift-api-master-verify
  • pull-ci-openshift-api-master-verify-client-go
  • pull-ci-openshift-api-master-verify-crd-schema
  • pull-ci-openshift-api-master-verify-deps

In response to this:

/retest verify-client-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 6, 2024 •
edited by openshift-ci bot
Loading

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.18" instead.

In response to this:

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2024
@atiratree atiratree force-pushed the bump-1.31 branch 3 times, most recently from c3fd90e to f1867d7 Compare August 6, 2024 18:45
@atiratree
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 9, 2024 •
edited by openshift-ci bot
Loading

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

In response to this:

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 15, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 20, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2024
@atiratree atiratree mentioned this pull request Aug 30, 2024
Closed
atiratree and others added 16 commits September 11, 2024 16:23
@atiratree
bump(k8s): update k8s.io/* dependencies to v1.31.0
afd5383
@atiratree
bump(k8s): go mod vendor
5e969d5
@atiratree
bump(k8s): tools: update k8s.io/* dependencies to v1.31.0
c6131fd 
- removed exclude for github.com/sergi/go-diff as it should have been
  fixed by sergi/go-diff#136
@atiratree
bump(k8s): go mod vendor and tools: go mod vendor
73ac235
@atiratree
update openapi generator to use k8s.io/gengo/v2
36c5f3d
@atiratree
make apimachinery/pkg/version/ optional dependency for openapi genera…
5117c22 
…tion
@atiratree
bump(k8s): tools: make k8s.io/gengo/v2 explicit in go.mod
8571b67
@atiratree
bump(k8s): make update-openapi
b6e8d0f
@atiratree
fix update-protobuf.sh script
510177f
@atiratree
bump(k8s): make update-protobuf
dfd8aaf
@JoelSpeed @atiratree
Update pre-release lifecycle gen script
0926119
@atiratree
fix machine types for update-codegen-crds.sh
2d395e1
@atiratree
./hack/update-codegen-crds.sh
beedd3e
@atiratree
make update
def9058
@atiratree
fix verify-prerelease-lifecycle-gen.sh
37e117a 
--verify-only option has been removed, so use git diff instead
@atiratree
add new image fs type
a086367
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

@atiratree: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify e679839 link true /test verify
ci/prow/integration e679839 link true /test integration
ci/prow/e2e-gcp e679839 link false /test e2e-gcp
ci/prow/verify-crd-schema e679839 link true /test verify-crd-schema
ci/prow/verify-client-go e679839 link true /test verify-client-go

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@soltysh soltysh Awaiting requested review from soltysh

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atiratree @openshift-ci-robot @openshift-merge-robot @JoelSpeed