Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for perspective detection using extensions #5911

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Add support for perspective detection using extensions #5911

merged 1 commit into from
Jul 13, 2020

Conversation

rohitkrai03
Copy link
Contributor

@rohitkrai03 rohitkrai03 commented Jul 7, 2020 •
edited
Loading

Fixes: https://issues.redhat.com/browse/ODC-4022

Analysis / Root cause: We want a developer to be directly taken to developer perspective.

Solution Description:

  • Added a new perspective extension property usePerspectiveDetection which runs the perspective detection.
  • Created DetectPerspective component that wraps top level App component and runs perspective detection using the extension mechanism.

Screen shots / Gifs for design review:
perpsectives

perpsectives - 2

Unit test coverage report:
Screenshot from 2020-07-10 00-56-43

Screenshot from 2020-07-10 00-57-33

Screenshot from 2020-07-10 01-01-52

Test setup:

  • Remove last-perspective from local storage.
  • Login as basic user into the console.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Jul 7, 2020
@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console component/sdk Related to console-plugin-sdk labels Jul 7, 2020
@rohitkrai03
Copy link
Contributor Author

/retest

1 similar comment
@rohitkrai03
Copy link
Contributor Author

/retest

@rohitkrai03 rohitkrai03 force-pushed the perspective-detection branch 2 times, most recently from a81dcef to 49450e8 Compare July 9, 2020 21:02
@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 9, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@rohitkrai03
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@rohitkrai03
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@rohitkrai03
Copy link
Contributor Author

/hold
Seems like switching to developer perspective for basic users broke an e2e test that depends on it.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2020
@rohitkrai03
Copy link
Contributor Author

/hold cancel

Fixed the failing e2e tests.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2020
@andrewballantyne
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f3bb6c2 into openshift:master Jul 13, 2020
@rohitkrai03 rohitkrai03 mentioned this pull request Jul 13, 2020
Closed
@spadgett spadgett added this to the v4.6 milestone Jul 14, 2020
@spadgett spadgett mentioned this pull request Jul 20, 2020
Merged
@rohitkrai03 rohitkrai03 deleted the perspective-detection branch July 24, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianvogt christianvogt christianvogt left review comments

@spadgett spadgett Awaiting requested review from spadgett

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@andrewballantyne andrewballantyne

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/sdk Related to console-plugin-sdk lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.
7 participants
@rohitkrai03 @christianvogt @openshift-bot @andrewballantyne @openshift-ci-robot @spadgett @openshift-merge-robot