HOSTEDCP-1921: Remove unused CAPZ CRDs from HyperShift install #4618
Conversation
Remove unused CAPZ managed related CRDs from the HyperShift install since those are not used in HyperShift. Signed-off-by: Bryan Cox <brcox@redhat.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@bryan-cox: This pull request references HOSTEDCP-1903 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
area/cli
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/test all |
|
/test all |
2 similar comments
|
/test all |
|
/test all |
|
/retest |
1 similar comment
|
/retest-required |
|
/retest-required |
|
e2e-aks is legitimately failing. I'll take a look into it today. |
|
Looks like the error is related to this |
|
looks like we need to turn off |
Looks like we already turn that off - |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Moving this PR back to draft. This PR will be blocked for the moment. CAPZ is still registering the webhooks related to the CRDs even if the featuregate is disabled. |
bryan-cox
changed the title
|
@bryan-cox: This pull request references HOSTEDCP-1921 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@bryan-cox: This pull request references HOSTEDCP-1921 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
This is blocked from further progress until kubernetes-sigs/cluster-api-provider-azure#5099 is merged and HyperShift is updated to use the new CAPZ version including the fix. |
|
@bryan-cox: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/close |
|
@bryan-cox: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Remove unused CAPZ managed related CRDs from the HyperShift install since those are not used in HyperShift.
Which issue(s) this PR fixes:
Fixes HOSTEDCP-1921
Checklist