OCPBUGS-22216: Make lvmo version visible to users via configmap #2789

copejon · 2023-12-21T17:04:42Z

No description provided.

copejon · 2023-12-21T21:12:15Z

/test test-rebase

ggiguash · 2023-12-22T13:56:22Z

docs/contributor/storage/default_csi_plugin.md

+
+```shell
+$ oc get configmap -n openshift-storage lvms-version -o jsonpath='{.data.version}'
+v4.14.0-10


I think we want to display LVMS version when running microshift version as well?

No, we don't want the CSI driver more tightly coupled to the core service, any more than we do for other add-ons.

ggiguash · 2023-12-22T13:57:36Z

docs/contributor/storage/default_csi_plugin.md

+by image tag, with only the major version correlating the major MicroShift version.
+
+The LVMS version is not exposed by LVMS itself. For troublshooting purposes, MicroShift exposes the LVMS version 
+via a configmap in the `openshift-storage` namespace. To get the LVMS version, run the following command:


Please, also update the https://github.com/openshift/microshift/blob/main/docs/user/debugging_tips.md document in this PR

copejon · 2023-12-22T17:43:33Z

Something has goofed up the lvmd.yaml default config generation. Looking into it

ggiguash · 2023-12-23T08:28:17Z

/retitle OCPBUGS-22216: Make lvmo version visible to users via configmap

openshift-ci-robot · 2023-12-23T08:28:26Z

@copejon: This pull request references Jira Issue OCPBUGS-22216, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dhellmann · 2024-01-03T22:41:59Z

/retest-required

dhellmann · 2024-01-05T19:40:02Z

I suspect this needs to be rebased to pick up some of the recent fixes for test flakes.

pmtk

two minor formatting things, but looks good overall

scripts/auto-rebase/lvms_assets.yaml

scripts/auto-rebase/rebase-lvms.sh

copejon · 2024-01-10T17:55:50Z

/retest

copejon · 2024-01-12T15:17:08Z

/retest

copejon · 2024-01-15T14:15:00Z

/test microshift-metal-tests-arm

dhellmann · 2024-01-15T22:26:36Z

scripts/auto-rebase/rebase-lvms.sh

@@ -373,7 +397,7 @@ usage() {
    echo "$(basename "$0") to LVMS_RELEASE_IMAGE         Performs all the steps to rebase LVMS"
    echo "$(basename "$0") download LVMS_RELEASE_IMAGE   Downloads the content of a LVMS release image to disk in preparation for rebasing"
    echo "$(basename "$0") images                        Updates LVMS images"
-    echo "$(basename "$0") manifests                     Updates LVMS manifests"
+    echo "$(basename "$0") manifests LVMS_RELEASE_IMAGE  Updates LVMS manifests"


I think in the other rebase script the manifests command relies on the image already being downloaded. Instead of changing the interface here, could we have the 'download' command put the information needed by the 'manifests' command somewhere to be found later when 'manifests' is run?

dhellmann · 2024-01-16T20:42:25Z

assets/components/lvms/topolvm-configmap_lvms-version.yaml

+kind: ConfigMap
+metadata:
+  name: lvms-version
+  namespace: openshift-storage


The microshift-version config map goes into kube-public to ensure special RBAC rules aren't needed to read it. Will an agent using a service account need special permission to read data from this namespace?

AFAICT, new and existing SAs at least have view access to CMs across the cluster. Tested this by creating a namespace and using it's default SA to read the CM in the openshift-storage namespace.

That said, I'll move change it to the kube-public NS, should those permissions be tightened up in the future.

write CM to kube-public ns Signed-off-by: Jon Cope <jcope@redhat.com> add lvms version cm to openshift-storage ns Signed-off-by: Jon Cope <jcope@redhat.com>

copejon · 2024-01-22T22:27:31Z

Verify job is broken. Blocked until #2915 is merged

pacevedom · 2024-01-23T09:00:40Z

/test verify

pmtk · 2024-01-23T11:29:33Z

/lgtm

openshift-ci · 2024-01-23T11:30:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [copejon,pmtk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2024-01-23T12:51:08Z

@copejon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2024-01-23T12:51:45Z

@copejon: Jira Issue OCPBUGS-22216: All pull requests linked via external trackers have merged:

openshift/microshift#2789

Jira Issue OCPBUGS-22216 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

copejon · 2024-01-29T23:10:24Z

/cherry-pick release-4.15

openshift-cherrypick-robot · 2024-01-29T23:11:17Z

@copejon: new pull request created: #2946

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from pliurh and pmtk December 21, 2023 17:05

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2023

copejon changed the title ~~[OCPBUGS-22216] make lvmo version visible to users via configmap~~ [WIP][OCPBUGS-22216] make lvmo version visible to users via configmap Dec 21, 2023

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 21, 2023

copejon force-pushed the ocpbugs-22216-lvms-version-visibility branch 4 times, most recently from ed3906c to 92fe96b Compare December 21, 2023 20:31

copejon changed the title ~~[WIP][OCPBUGS-22216] make lvmo version visible to users via configmap~~ [OCPBUGS-22216] make lvmo version visible to users via configmap Dec 21, 2023

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 21, 2023

ggiguash reviewed Dec 22, 2023

View reviewed changes

openshift-ci bot changed the title ~~[OCPBUGS-22216] make lvmo version visible to users via configmap~~ OCPBUGS-22216: Make lvmo version visible to users via configmap Dec 23, 2023

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 23, 2023

openshift-ci bot requested a review from jogeo December 23, 2023 08:28

pmtk reviewed Jan 8, 2024

View reviewed changes

scripts/auto-rebase/lvms_assets.yaml Outdated Show resolved Hide resolved

scripts/auto-rebase/rebase-lvms.sh Outdated Show resolved Hide resolved

copejon force-pushed the ocpbugs-22216-lvms-version-visibility branch from e61661d to 3bbde74 Compare January 8, 2024 20:01

copejon force-pushed the ocpbugs-22216-lvms-version-visibility branch 3 times, most recently from 330188f to 509d867 Compare January 11, 2024 23:15

copejon force-pushed the ocpbugs-22216-lvms-version-visibility branch from 6782543 to 5fa1ac3 Compare January 15, 2024 16:35

dhellmann reviewed Jan 15, 2024

View reviewed changes

dhellmann reviewed Jan 16, 2024

View reviewed changes

copejon force-pushed the ocpbugs-22216-lvms-version-visibility branch 4 times, most recently from 35eeb5f to cd48efc Compare January 22, 2024 19:32

dump version during download, read during manifest gen

690d5cb

write CM to kube-public ns Signed-off-by: Jon Cope <jcope@redhat.com> add lvms version cm to openshift-storage ns Signed-off-by: Jon Cope <jcope@redhat.com>

copejon force-pushed the ocpbugs-22216-lvms-version-visibility branch from cd48efc to 690d5cb Compare January 22, 2024 20:14

openshift-ci bot assigned pmtk Jan 23, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2024

openshift-merge-bot bot merged commit 6c8bddd into openshift:main Jan 23, 2024
9 checks passed

openshift-cherrypick-robot mentioned this pull request Jan 29, 2024

[release-4.15] OCPBUGS-28606: Make lvmo version visible to users via configmap #2946

Merged

copejon deleted the ocpbugs-22216-lvms-version-visibility branch April 30, 2024 21:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-22216: Make lvmo version visible to users via configmap #2789

OCPBUGS-22216: Make lvmo version visible to users via configmap #2789

copejon commented Dec 21, 2023

copejon commented Dec 21, 2023

ggiguash Dec 22, 2023

dhellmann Dec 22, 2023

ggiguash Dec 22, 2023

copejon commented Dec 22, 2023

ggiguash commented Dec 23, 2023

openshift-ci-robot commented Dec 23, 2023

dhellmann commented Jan 3, 2024

dhellmann commented Jan 5, 2024

pmtk left a comment

copejon commented Jan 10, 2024

copejon commented Jan 12, 2024

copejon commented Jan 15, 2024

dhellmann Jan 15, 2024

dhellmann Jan 16, 2024

copejon Jan 17, 2024 •

edited

Loading

copejon commented Jan 22, 2024

pacevedom commented Jan 23, 2024

pmtk commented Jan 23, 2024

openshift-ci bot commented Jan 23, 2024

openshift-ci bot commented Jan 23, 2024

openshift-ci-robot commented Jan 23, 2024

copejon commented Jan 29, 2024

openshift-cherrypick-robot commented Jan 29, 2024

OCPBUGS-22216: Make lvmo version visible to users via configmap #2789

OCPBUGS-22216: Make lvmo version visible to users via configmap #2789

Conversation

copejon commented Dec 21, 2023

copejon commented Dec 21, 2023

ggiguash Dec 22, 2023

Choose a reason for hiding this comment

dhellmann Dec 22, 2023

Choose a reason for hiding this comment

ggiguash Dec 22, 2023

Choose a reason for hiding this comment

copejon commented Dec 22, 2023

ggiguash commented Dec 23, 2023

openshift-ci-robot commented Dec 23, 2023

dhellmann commented Jan 3, 2024

dhellmann commented Jan 5, 2024

pmtk left a comment

Choose a reason for hiding this comment

copejon commented Jan 10, 2024

copejon commented Jan 12, 2024

copejon commented Jan 15, 2024

dhellmann Jan 15, 2024

Choose a reason for hiding this comment

dhellmann Jan 16, 2024

Choose a reason for hiding this comment

copejon Jan 17, 2024 • edited Loading

Choose a reason for hiding this comment

copejon commented Jan 22, 2024

pacevedom commented Jan 23, 2024

pmtk commented Jan 23, 2024

openshift-ci bot commented Jan 23, 2024

openshift-ci bot commented Jan 23, 2024

openshift-ci-robot commented Jan 23, 2024

copejon commented Jan 29, 2024

openshift-cherrypick-robot commented Jan 29, 2024

copejon Jan 17, 2024 •

edited

Loading