Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-2473: add missing quote to microshift-ext template #3094

Conversation

dhellmann
Copy link
Contributor

/assign @jogeo

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 1, 2024

@dhellmann: This pull request references USHIFT-2473 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

/assign @jogeo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 1, 2024
@openshift-ci openshift-ci bot requested review from ggiguash and pmtk March 1, 2024 16:41
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2024
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

@dhellmann: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jogeo
Copy link
Contributor

jogeo commented Mar 1, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2024
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, jogeo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 91ba4a2 into openshift:main Mar 1, 2024
6 checks passed
@ggiguash
Copy link
Contributor

ggiguash commented Apr 1, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot

@ggiguash: #3094 failed to apply on top of branch "release-4.15":

Applying: USHIFT-2473: add missing quote to microshift-ext template
Using index info to reconstruct a base tree...
A	test/image-blueprints/layer4-ext/group1/rhel93_microshift-ext.toml
Falling back to patching base and 3-way merge...
Auto-merging test/image-blueprints/layer3-periodic/group1/rhel93-source.toml
CONFLICT (content): Merge conflict in test/image-blueprints/layer3-periodic/group1/rhel93-source.toml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 USHIFT-2473: add missing quote to microshift-ext template
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants