Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-2459: Add docs to namespaceOwnership #3148

Merged
merged 1 commit into from
Mar 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/generate-config/config/config-openapi-spec.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
],
"properties": {
"namespaceOwnership": {
"description": "Describes how host name claims across namespaces should be handled. \n Value must be one of: \n - Strict: Do not allow routes in different namespaces to claim the same host. \n - InterNamespaceAllowed: Allow routes to claim different paths of the same host name across namespaces. \n If empty, the default is InterNamespaceAllowed.",
"type": "string",
"default": "InterNamespaceAllowed"
}
Expand Down
5 changes: 5 additions & 0 deletions packaging/microshift/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ etcd:
memoryLimitMB: 0
ingress:
routeAdmissionPolicy:
# Describes how host name claims across namespaces should be handled.
# Value must be one of:
# - Strict: Do not allow routes in different namespaces to claim the same host.
# - InterNamespaceAllowed: Allow routes to claim different paths of the same host name across namespaces.
# If empty, the default is InterNamespaceAllowed.
namespaceOwnership: InterNamespaceAllowed
manifests:
# The locations on the filesystem to scan for kustomization files to use to load manifests. Set to a list of paths to scan only those paths. Set to an empty list to disable loading manifests. The entries in the list can be glob patterns to match multiple subdirectories.
Expand Down
10 changes: 10 additions & 0 deletions pkg/config/ingress.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,16 @@ type IngressConfig struct {
}

type RouteAdmissionPolicy struct {
// Describes how host name claims across namespaces should be handled.
//
// Value must be one of:
//
// - Strict: Do not allow routes in different namespaces to claim the same host.
//
// - InterNamespaceAllowed: Allow routes to claim different paths of the same
// host name across namespaces.
//
// If empty, the default is InterNamespaceAllowed.
// +kubebuilder:default="InterNamespaceAllowed"
NamespaceOwnership NamespaceOwnershipEnum `json:"namespaceOwnership"`
}