-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USHIFT-2942: Template interfaces in Multus tests and enable bootc-optional scenario #3231
USHIFT-2942: Template interfaces in Multus tests and enable bootc-optional scenario #3231
Conversation
@pmtk: This pull request references USHIFT-2942 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold |
8d249f8
to
2daefcc
Compare
scenario_create_vms() { | ||
prepare_kickstart host1 kickstart-bootc.ks.template cos9-bootc-source-optionals | ||
# Two nics - one for macvlan, another for ipvlan (they cannot enslave the same interface) | ||
launch_vm host1 centos9 "${VM_MULTUS_NETWORK}" "" "" "" "2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"1" is missing in the end to enable bootc mounts.
2daefcc
to
6a86b40
Compare
/lgtm |
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pmtk: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.