-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-34491: fix: adjust topolvm controller probes #3433
OCPBUGS-34491: fix: adjust topolvm controller probes #3433
Conversation
@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-34491, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
/jira refresh |
/test all |
@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-34491, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
aa4adb8
to
42ec8ee
Compare
/test all |
42ec8ee
to
c8c87b5
Compare
/test all |
c8c87b5
to
a59c784
Compare
/test all |
@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-34491, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
a59c784
to
d2e0ad5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
d2e0ad5
to
69efc8b
Compare
had to rebase... |
/test test-rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev, pacevedom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jakobmoellerdev: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@jakobmoellerdev: Jira Issue OCPBUGS-34491: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-34491 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Which issue(s) this PR addresses:
Changes the readinessProbe of topolvm-controller to use /readyz instead of /metrics.
Removes the initial delay of 10s because we also have a 2s startup probe that ensures that the probes should exist
Closes #