NO-ISSUE: Update asset.yaml source for the route crd #3449
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@copejon: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
copejon
force-pushed
the
no-issue-change-route-crd-src
branch
from
0fe0d8e
to
a7e8867
Compare
|
/cherry-pick release-4.16 |
|
@copejon: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Are we sure the CRD in the router repo is the one we want? The PR where route/v1/route.crd.yaml was introduced claims that it superseded https://github.com/openshift/router/blob/master/deploy/route_crd.yaml . It also looks substantially different than e.g. https://github.com/openshift/api/blob/master/route/v1/zz_generated.crd-manifests/routes-Default.crd.yaml . |
… which should provide a more stable path added cluster-config-api to embedded components so that the rebase script includes openshift/api during the git clone staging
copejon
force-pushed
the
no-issue-change-route-crd-src
branch
from
a7e8867
to
7285d10
Compare
|
@jerpeter1 I've updated the PR per your recommendation. The rebase script will clone the openshift/api repository and copy the routes-Default.crd.yaml file. |
|
@copejon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: copejon, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@copejon: new pull request created: #3456 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The route API CRD was previously source from the route-controller-manager. This has proven to be problematic since the source file path has change in the last release. MicroShift should source the CRD from the router repository instead, which should be safer in the future.
The source path used here is
amd64. It doesn't matter which arch is manifest is pulled from since the CRD is not arch-dependent.