Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-35507: Fix CRI-O version to match Kubernetes version #3491

Merged
merged 1 commit into from
Jun 20, 2024
Merged

OCPBUGS-35507: Fix CRI-O version to match Kubernetes version #3491

merged 1 commit into from
Jun 20, 2024

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Jun 14, 2024

No description provided.

@pmtk
Copy link
Member Author

pmtk commented Jun 14, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2024
@openshift-ci openshift-ci bot requested review from jerpeter1 and pliurh June 14, 2024 15:23
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2024
@pmtk pmtk force-pushed the rpm-spec-crio-ver/main branch 2 times, most recently from 4ca7a3a to 3c720ac Compare June 14, 2024 15:48
@pmtk pmtk changed the title Fix CRI-O version to match Kubernetes version OCPBUGS-35507: Fix CRI-O version to match Kubernetes version Jun 14, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 14, 2024
@openshift-ci-robot
Copy link

@pmtk: This pull request references Jira Issue OCPBUGS-35507, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pmtk
Copy link
Member Author

pmtk commented Jun 17, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 17, 2024
@openshift-ci-robot
Copy link

@pmtk: This pull request references Jira Issue OCPBUGS-35507, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from jogeo June 17, 2024 11:37
@pmtk pmtk force-pushed the rpm-spec-crio-ver/main branch 2 times, most recently from 83c104e to f89278c Compare June 17, 2024 13:00
@pmtk
Copy link
Member Author

pmtk commented Jun 17, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2024
ggiguash
ggiguash reviewed Jun 17, 2024
View reviewed changes
packaging/rpm/microshift.spec Outdated Show resolved Hide resolved
scripts/devenv-builder/configure-vm.sh Outdated Show resolved Hide resolved
@pmtk pmtk force-pushed the rpm-spec-crio-ver/main branch 3 times, most recently from 10845bd to 4a91f3f Compare June 17, 2024 15:05
ggiguash
ggiguash reviewed Jun 17, 2024
View reviewed changes
test/bin/build_images.sh Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD dbe80c3 and 2 for PR HEAD 436c0e7 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e9533cf and 1 for PR HEAD 436c0e7 in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2024
@pmtk pmtk force-pushed the rpm-spec-crio-ver/main branch 2 times, most recently from 7c9649c to c7261bc Compare June 19, 2024 08:37
ggiguash
ggiguash reviewed Jun 19, 2024
View reviewed changes
packaging/rpm/microshift.spec Outdated
@@ -474,6 +474,9 @@ fi
# Use Git command to generate the log and replace the VERSION string
# LANG=C git log --date="format:%a %b %d %Y" --pretty="tformat:* %cd %an <%ae> VERSION%n- %s%n" packaging/rpm/microshift.spec
%changelog
* Fri Jun 14 2024 Patryk Matuszak <pmatusza@redhat.com> 4.16.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a 4.17.0 change, right? Because we bumped the crio version to 1.30.

@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2024
@pmtk
Copy link
Member Author

pmtk commented Jun 19, 2024

/test metal-bootc-test metal-periodic-test microshift-metal-tests

@pmtk
Copy link
Member Author

pmtk commented Jun 19, 2024

/test metal-bootc-test microshift-metal-tests

@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmtk
Copy link
Member Author

pmtk commented Jun 19, 2024

/test metal-bootc-test microshift-metal-tests

@pmtk
Copy link
Member Author

pmtk commented Jun 19, 2024

/override ci/prow/metal-periodic-test
FIPS

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 19, 2024

@pmtk: Overrode contexts on behalf of pmtk: ci/prow/metal-periodic-test

In response to this:

/override ci/prow/metal-periodic-test
FIPS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bb13dd5 and 2 for PR HEAD b45d2cb in total

@pmtk
Copy link
Member Author

pmtk commented Jun 19, 2024

/test metal-bootc-test

1 similar comment
@ggiguash
Copy link
Contributor

/test metal-bootc-test

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 20, 2024

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 46e94fc into openshift:main Jun 20, 2024
11 checks passed
@openshift-ci-robot
Copy link

@pmtk: Jira Issue OCPBUGS-35507: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35507 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pmtk pmtk deleted the rpm-spec-crio-ver/main branch June 20, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggiguash ggiguash ggiguash left review comments

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

@pliurh pliurh Awaiting requested review from pliurh

@jogeo jogeo Awaiting requested review from jogeo

Assignees

@ggiguash ggiguash

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmtk @openshift-ci-robot @ggiguash