Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-3136: Fix remove_vm function to keep info files when not fully deleted #3492

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Jun 15, 2024

When a VM creation is retried, we need to keep the metadata in the vms/${vmname} directory because it may be reused on the next iteration.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 15, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 15, 2024

@ggiguash: This pull request references USHIFT-3136 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from copejon and pliurh June 15, 2024 17:39
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2024
@ggiguash
Copy link
Contributor Author

/cherry-pick release-4.16
/cherry-pick release-4.15

@openshift-cherrypick-robot

@ggiguash: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.16
/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ggiguash
Copy link
Contributor Author

Failure because of the FIPS problem.
/override ci/prow/metal-periodic-test
/test metal-bootc-test-arm

Copy link
Contributor

openshift-ci bot commented Jun 16, 2024

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/metal-periodic-test

In response to this:

Failure because of the FIPS problem.
/override ci/prow/metal-periodic-test
/test metal-bootc-test-arm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jun 16, 2024

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 17, 2024

@ggiguash: This pull request references USHIFT-3136 which is a valid jira issue.

In response to this:

When a VM creation is retried, we need to keep the metadata in the vms/${vmname} directory because it is reused on the next iteration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 17, 2024

@ggiguash: This pull request references USHIFT-3136 which is a valid jira issue.

In response to this:

When a VM creation is retried, we need to keep the metadata in the vms/${vmname} directory because it may be reused on the next iteration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pmtk
Copy link
Member

pmtk commented Jun 17, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2024
Copy link
Contributor

openshift-ci bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9fe470a into openshift:main Jun 17, 2024
10 checks passed
@openshift-cherrypick-robot

@ggiguash: new pull request created: #3498

In response to this:

/cherry-pick release-4.16
/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@ggiguash: new pull request created: #3499

In response to this:

/cherry-pick release-4.16
/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ggiguash
Copy link
Contributor Author

ggiguash commented Jun 17, 2024

/retitle USHIFT-3136: Fix remove_vm function to keep info files when not fully deleted

@ggiguash ggiguash deleted the fix_retries branch June 20, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants