Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-3271: Prevent pod name-collisions in storage tests #3516

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

copejon
Copy link
Contributor

@copejon copejon commented Jun 19, 2024

No description provided.

…uite, a pod may still be deleting when a new pod with the same name is created, which creates a name collision. extracted namespace generation into its own keyword and updated storage tests to create/cleanup a unique namespace per test case. this will isolate the pods and prevent name collisions

Signed-off-by: Jon Cope <jcope@redhat.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 19, 2024

@copejon: This pull request references USHIFT-3271 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 19, 2024
@openshift-ci openshift-ci bot requested review from jerpeter1 and pmtk June 19, 2024 19:24
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2024
…n before setting up kubeconfig

Signed-off-by: Jon Cope <jcope@redhat.com>
@copejon
Copy link
Contributor Author

copejon commented Jun 20, 2024

/test microshift-metal-tests

1 similar comment
@ggiguash
Copy link
Contributor

/test microshift-metal-tests

test/suites/storage/pvc-resize.robot Outdated Show resolved Hide resolved
test/suites/storage/reboot.robot Outdated Show resolved Hide resolved
test/suites/storage/snapshot.robot Outdated Show resolved Hide resolved
Signed-off-by: Jon Cope <jcope@redhat.com>
@pacevedom
Copy link
Contributor

/test microshift-metal-tests
/test microshift-metal-tests-arm

@pacevedom
Copy link
Contributor

/test microshift-metal-tests

Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2024
Copy link
Contributor

openshift-ci bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jun 28, 2024

@copejon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ba72ed5 into openshift:main Jun 28, 2024
6 checks passed
@copejon copejon deleted the ushift-3271 branch August 13, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants