Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Add --showduplicates to dnf repository-packages #3536

Merged

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Jun 24, 2024

If newer CRI-O is installed than CRI-O present in the inspected repository then DNF will not consider it, meaning it will pretend like there is no CRI-O in the inspected repository.

By adding --showduplicates DNF will show information about the CRI-O in the repository regardless if newer is installed on the system or not.

If newer CRI-O is installed than CRI-O present in the inspected
repository then DNF will not consider it, meaning it will pretend like
there is no CRI-O in the inspected repository.

By adding --showduplicates DNF will show information about the CRI-O in
the repository regardless if newer is installed on the system or not.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 24, 2024
@openshift-ci-robot
Copy link

@pmtk: This pull request explicitly references no jira issue.

In response to this:

If newer CRI-O is installed than CRI-O present in the inspected repository then DNF will not consider it, meaning it will pretend like there is no CRI-O in the inspected repository.

By adding --showduplicates DNF will show information about the CRI-O in the repository regardless if newer is installed on the system or not.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pmtk
Copy link
Member Author

pmtk commented Jun 24, 2024

/assign @agullon

@openshift-ci openshift-ci bot requested review from jogeo and pliurh June 24, 2024 12:33
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2024
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2024
Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 13692e9 into openshift:main Jun 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants