Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Enable rhocp repos if mirror is used #3556

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

pacevedom
Copy link
Contributor

When $current_minor beta mirror is enabled we may also need the $previous_minor rhocp repo enabled. This is necessary for example for some scenarios.

Which issue(s) this PR addresses:

Closes #

When $current_minor beta mirror is enabled we may also need the
$previous_minor rhocp repo enabled. This is necessary for example
for some scenarios.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 28, 2024
@openshift-ci-robot
Copy link

@pacevedom: This pull request explicitly references no jira issue.

In response to this:

When $current_minor beta mirror is enabled we may also need the $previous_minor rhocp repo enabled. This is necessary for example for some scenarios.

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from copejon and pmtk June 28, 2024 12:12
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2024
@eslutsky
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2024
Copy link
Contributor

openshift-ci bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eslutsky, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jun 28, 2024

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b618ef7 into openshift:main Jun 28, 2024
6 checks passed
pacevedom added a commit to pacevedom/microshift that referenced this pull request Jun 28, 2024
Manually add this repo to the configure-vm.sh script. The
get_latest_rhocp_repo has been returning 4.15 and inadvertently
enabling that repo until 4.16 went GA and the repo was publicly
available. Now that this is the case, the scenario preparation for
upgrade tests fails, as there is no repo configured to pull those
packages.
This PR fixes that by adding not just 4.16 repo, but also 4.15.
This is a manual cherry-pick of openshift#3556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants