Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-3730: Introduce common versions file for image builds #3585

Merged
merged 6 commits into from
Jul 8, 2024
Merged

USHIFT-3730: Introduce common versions file for image builds #3585

merged 6 commits into from
Jul 8, 2024

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Jul 4, 2024

No description provided.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 4, 2024 •
edited by openshift-ci bot
Loading

@ggiguash: This pull request references USHIFT-3730 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 4, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
@ggiguash ggiguash force-pushed the common_versions branch 3 times, most recently from e618e4b to d91108f Compare July 4, 2024 08:54
@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 4, 2024

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 4, 2024

@ggiguash: The following commands are available to trigger required jobs:

  • /test images
  • /test metal-bootc-test
  • /test metal-bootc-test-arm
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test ocp-full-conformance-rhel-eus
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-metal-bootc-test
  • pull-ci-openshift-microshift-main-metal-bootc-test-arm
  • pull-ci-openshift-microshift-main-metal-periodic-test
  • pull-ci-openshift-microshift-main-metal-periodic-test-arm
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 4, 2024

/test metal-bootc-test
/test microshift-metal-tests

1 similar comment
@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 4, 2024

/test metal-bootc-test
/test microshift-metal-tests

@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 4, 2024

/test metal-bootc-test
/test microshift-metal-tests
/test metal-periodic-test

@ggiguash ggiguash marked this pull request as ready for review July 4, 2024 12:30
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2024
@openshift-ci openshift-ci bot requested review from jerpeter1 and pmtk July 4, 2024 12:30
@ggiguash ggiguash force-pushed the common_versions branch 4 times, most recently from 71b7667 to a106dd3 Compare July 4, 2024 13:21
@ggiguash ggiguash mentioned this pull request Jul 4, 2024
Closed
@ggiguash ggiguash marked this pull request as draft July 4, 2024 16:47
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2024
@ggiguash ggiguash marked this pull request as ready for review July 4, 2024 16:47
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2024
@openshift-ci openshift-ci bot requested a review from jogeo July 4, 2024 16:48
@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 4, 2024

/assign @pmtk @pacevedom

@ggiguash ggiguash marked this pull request as draft July 5, 2024 17:14
@ggiguash ggiguash marked this pull request as ready for review July 5, 2024 17:15
@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 5, 2024

/retest-required

@ggiguash ggiguash marked this pull request as draft July 5, 2024 17:18
@ggiguash ggiguash marked this pull request as ready for review July 5, 2024 17:19
@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 5, 2024

/test all

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 5, 2024
@openshift-ci openshift-ci bot requested review from copejon, pliurh and pmtk July 5, 2024 17:55
@ggiguash ggiguash mentioned this pull request Jul 6, 2024
Merged
@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 6, 2024

/retest-required

@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 6, 2024

/test all

@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 7, 2024

/retest-required

1 similar comment
@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 7, 2024

/retest-required

@pmtk
Copy link
Member

pmtk commented Jul 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 8, 2024

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 70b32e1 into openshift:main Jul 8, 2024
10 checks passed
@ggiguash ggiguash deleted the common_versions branch July 9, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

@jogeo jogeo Awaiting requested review from jogeo

@copejon copejon Awaiting requested review from copejon

@pliurh pliurh Awaiting requested review from pliurh

@pmtk pmtk Awaiting requested review from pmtk

Assignees

@pmtk pmtk

@pacevedom pacevedom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggiguash @openshift-ci-robot @pmtk @pacevedom