USHIFT-3740: ovnk configuration changes for ipv6 #3607
Conversation
Since this commit: ovn-org/ovn-kubernetes#4122 We dont need the next-hop for local gateway configuration, as it is automatically calculated.
openshift-ci-robot
added
the
jira/valid-reference
|
@pacevedom: This pull request references USHIFT-3740 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
| @@ -29,7 +29,6 @@ data: | |||
| [gateway] | |||
| mode=local | |||
| nodeport=true | |||
| next-hop=169.254.169.4 | |||
There was a problem hiding this comment.
This change requires some explaination. I remember we added it to solve some problem.
Can we track the original change and explain why removing this setting does not break the system?
There was a problem hiding this comment.
Yes, there is a reference to the original change in ovnk in the commit message: 9b7a506
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pacevedom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pacevedom: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Which issue(s) this PR addresses:
Closes #