USHIFT-3742: test if all the running pods are annotated for workload partitioning #3608
Conversation
openshift-ci
bot
added
the
approved
eslutsky
force-pushed
the
wp-test-control-pods-annontation
branch
2 times, most recently
from
87ce9e4
to
0ac6042
Compare
eslutsky
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@eslutsky: This pull request references USHIFT-3742 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
eslutsky
force-pushed
the
wp-test-control-pods-annontation
branch
3 times, most recently
from
2afa28c
to
8f0d521
Compare
| @{pods}= Split String ${pods_raw} | ||
| FOR ${pod} IN @{pods} | ||
| ${ns} ${pod}= Split String ${pod} \@ | ||
| ${csv_dss}= Check Pod Management Annotation ${ns} ${pod} |
There was a problem hiding this comment.
Does not look like the check function returns any values, right?
There was a problem hiding this comment.
no it doesnt return, changed the name.
| Oc Get All Pods | ||
| [Documentation] Runs 'oc get pods -A` | ||
| ... Returns the command output as formatted string <name-space>@<pod-name> | ||
|
|
||
| ${data}= Run With Kubeconfig | ||
| ... oc get pods -A -o jsonpath='{range .items[*]}{.metadata.namespace}{"@"}{.metadata.name}{"\\n"}{end}' | ||
| RETURN ${data} |
There was a problem hiding this comment.
Can we reuse the existing Oc Get JsonPath function from oc.resource?
There was a problem hiding this comment.
we could, but the original function Oc Get JsonPath only works with a specified namespace, the idea here is that we want to get all the pods across all namespaces.
There was a problem hiding this comment.
so we would need to refactor it to support -A
There was a problem hiding this comment.
I think let's refactor rather than creating a copy of the code.
The easiest way should be to check the namespace argument value and if it's empty, pass -A to the command.
eslutsky
force-pushed
the
wp-test-control-pods-annontation
branch
from
8f0d521
to
3a76047
Compare
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: Evgeny Slutsky <eslutsky@redhat.com>
eslutsky
force-pushed
the
wp-test-control-pods-annontation
branch
from
3a76047
to
ded674c
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eslutsky, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@eslutsky: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Which issue(s) this PR addresses:
Closes #