Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Move upgrade tests back to periodics #3616

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Jul 10, 2024

No description provided.

@openshift-ci-robot
Copy link

@pmtk: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 10, 2024
@openshift-ci openshift-ci bot requested review from ggiguash and pliurh July 10, 2024 11:36
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@ggiguash
Copy link
Contributor

/test metal-periodic-test

@ggiguash
Copy link
Contributor

@pmtk , I think this PR requires #3615 to properly increase the greenboot timeouts, so that the tests pass.

@ggiguash
Copy link
Contributor

/test all

@pmtk pmtk force-pushed the move-upgrades-to-periodics branch from 81e02ea to 0905979 Compare July 11, 2024 10:18
@pmtk
Copy link
Member Author

pmtk commented Jul 12, 2024

/retest

@ggiguash
Copy link
Contributor

/test all

@ggiguash
Copy link
Contributor

/test metal-periodic-test
/test metal-periodic-test-arm

@ggiguash
Copy link
Contributor

I'm approving this PR. The failures are related to FIPS which is another known problem.
However the main issue seems to be fixed. All VMs are starting successfully and greenboot failures are no longer present.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2024
@ggiguash
Copy link
Contributor

/override ci/prow/metal-periodic-test ci/prow/metal-periodic-test-arm

Copy link
Contributor

openshift-ci bot commented Jul 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jul 14, 2024

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/metal-periodic-test, ci/prow/metal-periodic-test-arm

In response to this:

/override ci/prow/metal-periodic-test ci/prow/metal-periodic-test-arm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jul 14, 2024

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c863141 into openshift:main Jul 14, 2024
8 checks passed
@pmtk pmtk deleted the move-upgrades-to-periodics branch July 15, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants