Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-3001: Add initial RF ipv6 tests #3658

Merged
merged 10 commits into from
Jul 24, 2024

Conversation

pacevedom
Copy link
Contributor

Which issue(s) this PR addresses:

Closes #

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 18, 2024

@pacevedom: This pull request references USHIFT-3001 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 18, 2024
@openshift-ci openshift-ci bot requested review from copejon and jerpeter1 July 18, 2024 15:49
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024
@pacevedom
Copy link
Contributor Author

/retest-required

@pacevedom
Copy link
Contributor Author

/hold
Need to fix a routing issue.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2024
@pacevedom
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2024
@pacevedom
Copy link
Contributor Author

/test metal-periodic-test-arm

... Expects RF runner host has opened port 5353 for libvirt zone.

${result}= Run Process
... avahi-resolve-host-name ${HOSTNAME}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it returned hello-microshift.cluster.local 2001:db8:ca7:ff::1522. Do think it's possible to have a race condition with another test that would also expose hello-microshift.cluster.local?

Should we check if the IP we got is indeed IPv6?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good points, did both.

Use hello-microshift.ipv6.cluster.local to avoid collisions with
other tests running at the same time.
@pmtk
Copy link
Member

pmtk commented Jul 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
@pmtk
Copy link
Member

pmtk commented Jul 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacevedom
Copy link
Contributor Author

/retest-required

@pacevedom
Copy link
Contributor Author

/test metal-periodic-test-arm

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a9c820e and 2 for PR HEAD e3e4059 in total

@pacevedom
Copy link
Contributor Author

Periodic tests failing because of the crel upgrade issue described here: https://redhat-internal.slack.com/archives/C0310LGMQQY/p1721797490189859

@pacevedom
Copy link
Contributor Author

/override ci/prow/metal-periodic-test
/override ci/prow/metal-periodic-test-arm

Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

@pacevedom: Overrode contexts on behalf of pacevedom: ci/prow/metal-periodic-test, ci/prow/metal-periodic-test-arm

In response to this:

/override ci/prow/metal-periodic-test
/override ci/prow/metal-periodic-test-arm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 93f7738 into openshift:main Jul 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants