Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-3788: Workload partitioning RF tests #3700

Merged

Conversation

eslutsky
Copy link
Contributor

Which issue(s) this PR addresses:

Closes #

@openshift-ci openshift-ci bot requested review from copejon and pacevedom July 31, 2024 15:43
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2024
test/suites/standard2/workload-partitioning.robot Outdated Show resolved Hide resolved
test/suites/standard2/workload-partitioning.robot Outdated Show resolved Hide resolved
Comment on lines 86 to 135
FOR ${pod} IN @{json_status}
${pod_info}= Catenate SEPARATOR=
... container: ${pod}[info][runtimeSpec][annotations][io.kubernetes.pod.name]
... ${EMPTY} pod: ${pod}[status][metadata][name]
... ${EMPTY} pid: ${pod}[info][pid]
... ${EMPTY} namespace: ${pod}[info][runtimeSpec][annotations][io.kubernetes.pod.namespace]

IF ${pod}[info][runtimeSpec][linux][resources][cpu][cpus] != ${cpus}
Fail ${pod_info}
END
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering what the jq version of this would look like. TIL this syntax

@eslutsky eslutsky changed the title Workload partionting RF tests USHIFT-3788: Workload partitioning RF tests Aug 1, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 1, 2024

@eslutsky: This pull request references USHIFT-3788 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 1, 2024
@eslutsky eslutsky force-pushed the WorkloadPartitioning_tests branch 9 times, most recently from c49bcc4 to 5236554 Compare August 2, 2024 10:45
@eslutsky eslutsky force-pushed the WorkloadPartitioning_tests branch 9 times, most recently from 91fd52e to 01706e4 Compare August 6, 2024 08:39
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2024
test/suites/standard2/workload-partitioning.robot Outdated Show resolved Hide resolved

Cleanup And Create NS
[Documentation] cleanup microshift and recreate the namespace for workloads
Cleanup MicroShift --all --keep-images
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind this line will eliminate /var/lib/microshift, meaning the kubeconfig in use is also gone and new certs are generated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have some other way to remove all the running containers ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok :) what I mean is that you need to setup kubeconfig again after doing a cleanup to have things under control.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, thats handled in Restart MicroShift keyword

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2024
@eslutsky eslutsky force-pushed the WorkloadPartitioning_tests branch 2 times, most recently from 7f541e2 to eae4e96 Compare August 7, 2024 11:03
@pacevedom
Copy link
Contributor

/lgtm
/hold
feel free to remove the hold once ready.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
Comment on lines +44 to +50
Configure Kubelet For Workload Partitioning ${MANAGEMENT_CPU}
Configure CRIO For Workload Partitioning ${MANAGEMENT_CPU}
Configure CPUAffinity In Systemd ${MANAGEMENT_CPU} ${SYSTEMD_CRIO_DROPIN}
Configure CPUAffinity In Systemd ${MANAGEMENT_CPU} ${SYSTEMD_MICROSHIFT_DROPIN}
Configure CPUAffinity In Systemd ${MANAGEMENT_CPU} ${SYSTEMD_OVS_DROPIN}
Configure CPUAffinity In Systemd ${MANAGEMENT_CPU} ${SYSTEMD_OVSDB_DROPIN}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about doing all this in a blueprint? So when the system is up then everything is already configured?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it makes sense , but i will have to change the reservedSystemCPUs: 0-1 in your blueprint to reservedSystemCPUs: 0 , since this test dont work very well with range of CPUs 0-1, wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we agreed off line that we can do this optimization later

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
Resource ../../resources/microshift-process.resource
Resource ../../resources/microshift-network.resource

Suite Setup Setup Suite With Namespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like previous test (tuned) does not wait for MicroShift readiness right after rebooting in the teardown. This can make this test run too fast and MicroShift is not available yet.
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_microshift/3700/pull-ci-openshift-microshift-main-microshift-metal-tests/1821188298421309440/artifacts/microshift-metal-tests/openshift-microshift-e2e-metal-tests/artifacts/scenario-info/el94-src@low-latency/log.html
Tuned teardown: Start / End / Elapsed: 20240807 17:13:21.895 / 20240807 17:13:58.041 / 00:00:36.146
workload partitioning setup trying to create a namespace: Start / End / Elapsed: 20240807 17:13:59.543 / 20240807 17:13:59.652 / 00:00:00.109
This failed because MicroShift is not up yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we already fixed that in the other PR, cherry picking the change.

Signed-off-by: Evgeny Slutsky <eslutsky@redhat.com>
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Feel free to unhold when you are ok with merging.

@eslutsky
Copy link
Contributor Author

eslutsky commented Aug 8, 2024

/unhold

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 8, 2024
Copy link
Contributor

openshift-ci bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eslutsky, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Aug 8, 2024

@eslutsky: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3d590fd into openshift:main Aug 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants