USHIFT-3494: Add explicit command line mode to virtual machine creation

[ggiguash]

I verified that any failure to the installation now invokes the kickstart %onerror handler.

The terminal output looks like this:

[   33.517655] anaconda[2628]: Installing.
[   34.520412] anaconda[2628]: The installation was stopped due to an error which occurred while running in non-interactive cmdline mode. Since there cannot be any questions in cmdline mode, edit your kickstart file and retry installation.
[   34.520498] anaconda[2628]: The exact error message is:
[   34.520680] anaconda[2628]: Non interactive installation failed: The command 'ostree container image deploy --sysroot=/mnt/sysimage --image=192.168.100.1:5000/rhel94-bootc-source --transport=registry' exited with the code 1..
[   34.520788] anaconda[2628]: The installer will now terminate.
Displaying log files on installation failure
---- /tmp/anaconda.log ----
05:35:38,756 INF core.configuration.product: Loading information about products from /etc/anaconda/product.d.
...
...
INFO:anaconda.threading:Thread Done: AnaTaskThread-MountFilesystemsTask-1 (139805871302208)
----      ----
Finished diplaying log files on installation failure

Note that the installation process actually stops after a short while and we fall back to the scenario.sh checking if the machine is up and running.

dracut Warning: Killing all remaining processes
[  224.656120] dracut Warning: Killing all remaining processes
dracut Warning: Unmounted /oldroot.
[  224.690980] dracut Warning: Unmounted /oldroot.
Rebooting.
[  224.758325] reboot: Restarting system

Domain has shutdown. Continuing.
Domain creation completed.
You can restart your domain by running:
  virsh --connect qemu:///system start el94-src-log-scan-host1
Domain 'el94-src-log-scan-host1' started

Waiting for VM el94-src-log-scan-host1 to have an IP
VM el94-src-log-scan-host1 has IP 192.168.100.246

The wait process finishes with a timeout and scenario.sh reports a VM creation failure as expected.

[openshift-ci-robot]

@ggiguash: This pull request references USHIFT-3494 which is a valid jira issue.

In response to this:

I verified that any failure to the installation now invokes the kickstart %onerror handler.

The terminal output looks like this:

[   33.517655] anaconda[2628]: Installing.
[   34.520412] anaconda[2628]: The installation was stopped due to an error which occurred while running in non-interactive cmdline mode. Since there cannot be any questions in cmdline mode, edit your kickstart file and retry installation.
[   34.520498] anaconda[2628]: The exact error message is:
[   34.520680] anaconda[2628]: Non interactive installation failed: The command 'ostree container image deploy --sysroot=/mnt/sysimage --image=192.168.100.1:5000/rhel94-bootc-source --transport=registry' exited with the code 1..
[   34.520788] anaconda[2628]: The installer will now terminate.
Displaying log files on installation failure
---- /tmp/anaconda.log ----
05:35:38,756 INF core.configuration.product: Loading information about products from /etc/anaconda/product.d.
...
...
INFO:anaconda.threading:Thread Done: AnaTaskThread-MountFilesystemsTask-1 (139805871302208)
----      ----
Finished diplaying log files on installation failure

Note that the installation process actually stops after a short while and we fall back to the scenario.sh checking if the machine is up and running.

dracut Warning: Killing all remaining processes
[  224.656120] dracut Warning: Killing all remaining processes
dracut Warning: Unmounted /oldroot.
[  224.690980] dracut Warning: Unmounted /oldroot.
Rebooting.
[  224.758325] reboot: Restarting system

Domain has shutdown. Continuing.
Domain creation completed.
You can restart your domain by running:
 virsh --connect qemu:///system start el94-src-log-scan-host1
Domain 'el94-src-log-scan-host1' started

Waiting for VM el94-src-log-scan-host1 to have an IP
VM el94-src-log-scan-host1 has IP 192.168.100.246

The wait process finishes with a timeout and scenario.sh reports a VM creation failure as expected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@ggiguash: This pull request references USHIFT-3494 which is a valid jira issue.

In response to this:

I verified that any failure to the installation now invokes the kickstart %onerror handler.

The terminal output looks like this:

[   33.517655] anaconda[2628]: Installing.
[   34.520412] anaconda[2628]: The installation was stopped due to an error which occurred while running in non-interactive cmdline mode. Since there cannot be any questions in cmdline mode, edit your kickstart file and retry installation.
[   34.520498] anaconda[2628]: The exact error message is:
[   34.520680] anaconda[2628]: Non interactive installation failed: The command 'ostree container image deploy --sysroot=/mnt/sysimage --image=192.168.100.1:5000/rhel94-bootc-source --transport=registry' exited with the code 1..
[   34.520788] anaconda[2628]: The installer will now terminate.
Displaying log files on installation failure
---- /tmp/anaconda.log ----
05:35:38,756 INF core.configuration.product: Loading information about products from /etc/anaconda/product.d.
...
...
INFO:anaconda.threading:Thread Done: AnaTaskThread-MountFilesystemsTask-1 (139805871302208)
----      ----
Finished diplaying log files on installation failure

Note that the installation process actually stops after a short while and we fall back to the scenario.sh checking if the machine is up and running.

dracut Warning: Killing all remaining processes
[  224.656120] dracut Warning: Killing all remaining processes
dracut Warning: Unmounted /oldroot.
[  224.690980] dracut Warning: Unmounted /oldroot.
Rebooting.
[  224.758325] reboot: Restarting system

Domain has shutdown. Continuing.
Domain creation completed.
You can restart your domain by running:
 virsh --connect qemu:///system start el94-src-log-scan-host1
Domain 'el94-src-log-scan-host1' started

Waiting for VM el94-src-log-scan-host1 to have an IP
VM el94-src-log-scan-host1 has IP 192.168.100.246

The wait process finishes with a timeout and scenario.sh reports a VM creation failure as expected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ggiguash]

/cherrypick release-4.16

[openshift-cherrypick-robot]

@ggiguash: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pmtk]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ggiguash,pmtk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-cherrypick-robot]

@ggiguash: #3743 failed to apply on top of branch "release-4.16":

Applying: Add explicit command line mode to virtual machine creation
Using index info to reconstruct a base tree...
M	test/bin/scenario.sh
Falling back to patching base and 3-way merge...
Auto-merging test/bin/scenario.sh
CONFLICT (content): Merge conflict in test/bin/scenario.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add explicit command line mode to virtual machine creation
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ggiguash]

/cherrypick release-4.17

[openshift-cherrypick-robot]

@ggiguash: new pull request created: #3745

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.