USHIFT-4061: change imagePullPolicy from Always to IfNotPresent #3768
Conversation
Signed-off-by: Evgeny Slutsky <eslutsky@redhat.com>
|
@eslutsky: This pull request references USHIFT-4061 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
approved
|
/retest |
| @@ -40,7 +40,7 @@ spec: | |||
| containers: | |||
| - name: dhcp-daemon | |||
| image: containernetworking-plugins-microshift | |||
| imagePullPolicy: Always | |||
| imagePullPolicy: IfNotPresent | |||
There was a problem hiding this comment.
Do we need to update the rebase script as well?
There was a problem hiding this comment.
AFAIK we dont rebase multus from upstream,
this is the ignore configuration:
https://github.com/openshift/microshift/blob/main/scripts/auto-rebase/assets.yaml#L257
which is checked here https://github.com/openshift/microshift/blob/main/scripts/auto-rebase/handle_assets.py#L99
@pmtk , correct me if am wrong..
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eslutsky, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@eslutsky: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherry-pick release-4.17 |
|
@eslutsky: new pull request created: #3854 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Which issue(s) this PR addresses:
Closes #