Use label-editor for PVC labels #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
kind/bug
|
The Learn More feels out of place as a block, try the inline one instead. |
spadgett
force-pushed
the
fix-label-regex
branch
from
77622f9
to
ef853a6
Compare
|
@jwforres Updated to use a checkbox instead:
|
Fixes a problem where the regex used for validating label names is wrong. Names with a `/` were incorrectly blocked.
spadgett
force-pushed
the
fix-label-regex
branch
from
ef853a6
to
0511d3f
Compare
jwforres
approved these changes
Nov 1, 2017
|
/lgtm |
|
@rusenask :) FIY . Done. |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem where the regex used for validating label names is
wrong. Names with a
/were incorrectly blocked.See discussion in #2414
/kind bug
/assign @jwforres
cc @mjudeikis