Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1505281 - Improve import YAML results message #2426

Merged

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Nov 1, 2017

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1505281
See also #2217

List:

openshift web console 2017-11-01 13-30-16

Single resource:

openshift web console 2017-11-01 13-46-08

/kind bug

cc @rhamilto @jwforres

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. labels Nov 1, 2017
@spadgett
Copy link
Member Author

spadgett commented Nov 1, 2017

Still testing the different scenarios

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 1, 2017
@spadgett
Copy link
Member Author

spadgett commented Nov 1, 2017

No change to processed templates:

openshift web console 2017-11-01 13-54-37

@jwforres
Copy link
Member

jwforres commented Nov 1, 2017

lgtm but
/hold
till you are done testing

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2017
@jwforres
Copy link
Member

jwforres commented Nov 1, 2017

guess i could've actually, still getting use to these fancy new options
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2017
@spadgett
Copy link
Member Author

spadgett commented Nov 1, 2017

Found a bug (#2427), but I think it's unrelated to this change.

@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2017
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 1, 2017
@spadgett spadgett changed the title [WIP] Bug 1505281 - Improve import YAML results message Bug 1505281 - Improve import YAML results message Nov 1, 2017
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2017
@spadgett
Copy link
Member Author

spadgett commented Nov 1, 2017

Rebased and rebuilt. Removing WIP.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2017
@spadgett
Copy link
Member Author

spadgett commented Nov 1, 2017

Reproduced #2427 without these changes.

@spadgett
Copy link
Member Author

spadgett commented Nov 1, 2017

Adding back the lgtm label since the last changes were a rebase only

@spadgett spadgett added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 84d6d04 into openshift:master Nov 1, 2017
@spadgett spadgett deleted the fix-import-yaml-msg branch November 1, 2017 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants