Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move master config ghosts to /etc/origin/master/ #15163

Merged
merged 1 commit into from
Nov 2, 2017
Merged

Move master config ghosts to /etc/origin/master/ #15163

merged 1 commit into from
Nov 2, 2017

Conversation

ashcrow
Copy link
Member

@ashcrow ashcrow commented Jul 12, 2017

@ashcrow ashcrow requested a review from sdodson July 12, 2017 13:31
@sdodson
Copy link
Member

sdodson commented Jul 12, 2017

Not calling this a blocker, we'll merge when master opens again.

@openshift-merge-robot openshift-merge-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 24, 2017
@sdodson
Copy link
Member

sdodson commented Jul 25, 2017

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to fbeb49f

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge FAILURE (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1374/) (Base Commit: 49df2d6) (PR Branch Commit: fbeb49f)

@openshift-merge-robot openshift-merge-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2017
@deads2k
Copy link
Contributor

deads2k commented Jul 31, 2017

/assign sdodson
/approve no-issue
/unassign

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2017
@ashcrow
Copy link
Member Author

ashcrow commented Oct 13, 2017

/test

@ashcrow
Copy link
Member Author

ashcrow commented Oct 30, 2017

/retest

@ashcrow
Copy link
Member Author

ashcrow commented Oct 31, 2017

/test extended_conformance_install_update

@sdodson
Copy link
Member

sdodson commented Oct 31, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, deads2k, sdodson

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@eparis eparis added the kind/bug Categorizes issue or PR as related to a bug. label Nov 1, 2017
@ashcrow
Copy link
Member Author

ashcrow commented Nov 1, 2017

@openshift-bot 🐝 😶

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

@ashcrow: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_gce fbeb49f link /test extended_conformance_gce
ci/openshift-jenkins/extended_conformance_install_update fbeb49f link /test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 15163, 17134).

@openshift-merge-robot openshift-merge-robot merged commit 07435db into openshift:master Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdodson sdodson sdodson approved these changes

Assignees

@sdodson sdodson

@eparis eparis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ashcrow @sdodson @openshift-bot @deads2k @openshift-merge-robot @openshift-ci-robot @eparis