Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 49142: Slow-start batch pod creation of rs, rc, ds, jobs #16111

Merged
merged 1 commit into from
Sep 13, 2017
Merged

UPSTREAM: 49142: Slow-start batch pod creation of rs, rc, ds, jobs #16111

merged 1 commit into from
Sep 13, 2017

Conversation

joelsmith
Copy link
Contributor

@joelsmith joelsmith commented Sep 1, 2017 •
edited

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 1, 2017
@deads2k
Copy link
Contributor

deads2k commented Sep 1, 2017

This looks fairly invasive. Is it a regression from 3.6? Did it get picked into 1.7? Is there an issue or bug corresponding to the pick?

@joelsmith
Copy link
Contributor Author

@deads2k sorry, I forgot to edit the PR comments with the xref to upstream. Also, I'm happy to have you review if you like, but @derekwaynecarr reviewed upstream so it might be easier to have him also review this pick PR. I'll go update the PR comment now with xref details.

@deads2k
Copy link
Contributor

deads2k commented Sep 1, 2017

@deads2k sorry, I forgot to edit the PR comments with the xref to upstream. Also, I'm happy to have you review if you like, but @derekwaynecarr reviewed upstream so it might be easier to have him also review this pick PR. I'll go update the PR comment now with xref details.

My concern is more about impacts to being able to pick future maintenance into 3.7. Having a description of the problem is important to judging the tradeoff. Thanks for the links.

@joelsmith
Copy link
Contributor Author

/test extended_conformance_gce

@joelsmith
Copy link
Contributor Author

The upstream PR has merged and will be in 1.8. @derekwaynecarr is this ready for a review?

@derekwaynecarr
Copy link
Member

@deads2k -- this protects against the following: kubernetes/kubernetes#49145

@derekwaynecarr
Copy link
Member

/assign @derekwaynecarr

@derekwaynecarr
Copy link
Member

@joelddiaz - i would like the upstream fix to soak a few days before merging this.

@derekwaynecarr
Copy link
Member

wrong joel, @joelsmith -- i want to let this soak for a few days upstream before merging.

@joelsmith
Copy link
Contributor Author

Thanks, sounds good.

@0xmichalis 0xmichalis removed their assignment Sep 9, 2017
@sjenning
Copy link
Contributor

@derekwaynecarr kubernetes/kubernetes#49142 has been in upstream 10 days now. How long did we want this to soak?

xref https://trello.com/c/vzi3Mhi3

@derekwaynecarr
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, joelsmith

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2017
@sjenning
Copy link
Contributor

integration test is currently broken #16323

@joelsmith
Copy link
Contributor Author

/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16295, 16314, 16326, 16111)

@openshift-merge-robot openshift-merge-robot merged commit 4f1394d into openshift:master Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@derekwaynecarr derekwaynecarr

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@joelsmith @deads2k @derekwaynecarr @sjenning @openshift-merge-robot @0xmichalis @openshift-ci-robot