Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 45345: Support "fstype" parameter in dynamically provisioned PVs #16232

Merged
merged 1 commit into from
Sep 8, 2017
Merged

UPSTREAM: 45345: Support "fstype" parameter in dynamically provisioned PVs #16232

merged 1 commit into from
Sep 8, 2017

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Sep 8, 2017

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 8, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2017
@jsafrane jsafrane assigned jsafrane and unassigned pmorie, deads2k and jsafrane Sep 8, 2017
@jsafrane
Copy link
Contributor Author

jsafrane commented Sep 8, 2017

/assign @rootfs @wongma7
FYI, there is an old azure_dd provisioner in 3.7 so I did not add fsType there. Rest of the provisioners is directly from referenced upstream PR.

@jsafrane jsafrane assigned rootfs and wongma7 and unassigned pmorie and deads2k Sep 8, 2017
@pospispa
Copy link

pospispa commented Sep 8, 2017

LGTM

@jsafrane
Copy link
Contributor Author

jsafrane commented Sep 8, 2017

/retest

@jsafrane
Copy link
Contributor Author

jsafrane commented Sep 8, 2017

filled #16235

@wongma7
Copy link
Contributor

wongma7 commented Sep 8, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, wongma7

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@wongma7
Copy link
Contributor

wongma7 commented Sep 8, 2017

/retest
#12072
#16246

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16241, 16232)

@openshift-merge-robot openshift-merge-robot merged commit a782cd4 into openshift:master Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rootfs rootfs

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jsafrane @pospispa @wongma7 @openshift-merge-robot @pmorie @rootfs @deads2k @openshift-ci-robot