Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream azure fixes #17052

Merged
merged 4 commits into from
Dec 5, 2017
Merged

Conversation

rootfs
Copy link
Member

@rootfs rootfs commented Oct 26, 2017

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 26, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Oct 26, 2017
@rootfs
Copy link
Member Author

rootfs commented Oct 26, 2017

@deads2k
Copy link
Contributor

deads2k commented Oct 26, 2017

@rootfs Do you have a bugzilla to link to in the description?

@rootfs
Copy link
Member Author

rootfs commented Oct 26, 2017

@deads2k not yet. This is an accumulated patch around multiple issues.

@rootfs
Copy link
Member Author

rootfs commented Oct 26, 2017

@deads2k BZ created.

@rootfs
Copy link
Member Author

rootfs commented Oct 26, 2017

/test extended_conformance_install_update

@childsb
Copy link
Contributor

childsb commented Oct 27, 2017

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 27, 2017
@childsb
Copy link
Contributor

childsb commented Oct 27, 2017

/retest

@childsb
Copy link
Contributor

childsb commented Oct 30, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2017
@0xmichalis
Copy link
Contributor

/test extended_conformance_install

@rootfs
Copy link
Member Author

rootfs commented Nov 17, 2017

@eparis can you merge? thanks

@rootfs
Copy link
Member Author

rootfs commented Nov 29, 2017

/assign @deads2k
can you approve? need it for a couple BZs.

@deads2k
Copy link
Contributor

deads2k commented Dec 1, 2017

/assign @deads2k
can you approve? need it for a couple BZs.

I'll
/approve

but because we're currently branching (jobs running as we speak), I need to

/hold

until this afternoon and you'll have to open a pull to release-3.8 too once we have it.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, deads2k, rootfs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2017
@deads2k
Copy link
Contributor

deads2k commented Dec 1, 2017

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2017
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 5, 2017

@rootfs: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_update 54542e0 link /test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 5a8373a into openshift:master Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants