UPSTREAM: 55631: Parse and return the last line in the log even if it is partial

[runcom]

Upstream issue: kubernetes/kubernetes#44976
Needed by CRI-O, @mrunalp PTAL

Signed-off-by: Antonio Murdaca [email protected]

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: runcom
We suggest the following additional approver: bparees

Assign the PR to them by writing /assign @bparees in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• vendor/k8s.io/kubernetes/pkg/kubelet/OWNERS

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[bparees]

/unassign

[ashcrow]

/test extended_conformance_gce

[runcom]

@smarterclayton @mrunalp PTAL

[runcom]

/test end_to_end

[mrunalp]

LGTM. This is needed to work around upstream CRI log parsing issue where it doesn't return the last line if it doesn't have a newline.

[ashcrow]

/retest

[ashcrow]

(Unrelated) Failed for extended_conformance_install_update:

INSTALL ANSIBLE ATOMIC-OPENSHIFT-UTILS

[derekwaynecarr]

@runcom the referenced upstream is related to DCOS getting started guide.

see: kubernetes/kubernetes#17198

what upstream are you actually intending to carry?

[runcom]

@runcom the referenced upstream is related to DCOS getting started guide.

see: kubernetes/kubernetes#17198

what upstream are you actually intending to carry?

yeah, sorry ,that's actually an issue in kube. There's no PR upstream for this patch /cc @mrunalp
This PR is actually breaking something in tests and @mrunalp is looking at it.

[liggitt]

There's no PR upstream for this patch

why not?

[mrunalp]

I created kubernetes/kubernetes#55631 to fix this upstream.

[derekwaynecarr]

I want to hold this PR merging in any branch until the corresponding upstream merges.

[mrunalp]

upstream for this has merged.

[runcom]

/test crio

[mrunalp]

@smarterclayton @stevekuznetsov We need this to fix the last crio test and start gating on crio in origin.

[derekwaynecarr]

/approve
/lgtm

[runcom]

/test crio

[runcom]

Submit Queue — PR does not have lgtm label.

@derekwaynecarr you need to re-post your /lgtm I guess

[stevekuznetsov]

/test crio
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, runcom, stevekuznetsov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• vendor/k8s.io/kubernetes/pkg/kubelet/OWNERS [derekwaynecarr,stevekuznetsov]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[runcom]

/test crio

[runcom]

/test crio

[runcom]

Cri-o test is hitting some weird failure on an unrelated test, this PR is fixing the issue so please merge it guys

[runcom]

@stevekuznetsov ^^

[stevekuznetsov]

This one is currently in the queue, will merge in due time

[runcom]

First CRI-O job fully green 🎉

[stevekuznetsov]

[openshift-ci-robot]

@runcom: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_conformance_install_update	d665d93	link	/test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-merge-robot]

Automatic merge from submit-queue.