Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 56356: Wait for controllerrevision informer to sync on statefulset controller startup #17513

Merged
merged 1 commit into from
Dec 5, 2017
Merged

UPSTREAM: 56356: Wait for controllerrevision informer to sync on statefulset controller startup #17513

merged 1 commit into from
Dec 5, 2017

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Nov 29, 2017 •
edited by liggitt

@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Nov 29, 2017
@mfojtik
Copy link
Contributor

mfojtik commented Nov 29, 2017 •
edited by tnozicka

/lgtm

@tnozicka
Copy link
Contributor Author

submit queue stuck...
/test all

@tnozicka
Copy link
Contributor Author

/test extended_conformance_install_update

@tnozicka
Copy link
Contributor Author

/retest

1 similar comment
@tnozicka
Copy link
Contributor Author

/retest

@tnozicka
Copy link
Contributor Author

I think SQ missed @mfojtik lgtm yesterday during the downtime

@liggitt
Copy link
Contributor

liggitt commented Nov 30, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mfojtik, tnozicka

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2017
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 1, 2017

/retest

@tnozicka tnozicka added this to the 3.8.0 milestone Dec 1, 2017
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 1, 2017

/retest

@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 1, 2017

/cherrypick release-3.8

@openshift-cherrypick-robot
Copy link

@tnozicka: @tnozicka once the present PR merges, I will cherry-pick it on top of release-3.8 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 3, 2017

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 4, 2017

/retest

2 similar comments
@0xmichalis
Copy link
Contributor

/retest

@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 4, 2017

/retest

@liggitt
Copy link
Contributor

liggitt commented Dec 5, 2017

/retest
also needs a pick to release-3.8 branch

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 5, 2017
@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 5, 2017

/retest
@liggitt pick to 3.8 is already scheduled (#17513 (comment)) once our CI starts working again and finally merges this

@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 5, 2017

/test extended_conformance_install_update

@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 5, 2017

/retest

@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 5, 2017

Flake: #17601
Flake: #17594
Flake: #17602

@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 5, 2017

flake: #17605
/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 5, 2017 •
edited

@tnozicka: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_crio 17c2084 link /test crio
ci/openshift-jenkins/extended_conformance_install_update 17c2084 link /test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 73f6852 into openshift:master Dec 5, 2017
@openshift-cherrypick-robot
Copy link

@tnozicka: New pull request created: #17609

In response to this:

/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 5, 2017
Closed
@tnozicka tnozicka deleted the backport-statefulset-revinformersync branch December 6, 2017 09:28
@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 6, 2017

/cherrypick release-3.7

@openshift-cherrypick-robot
Copy link

@tnozicka: new pull request created: #17620

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 6, 2017
Merged
openshift-merge-robot added a commit that referenced this pull request Jan 11, 2018
@openshift-merge-robot
Merge pull request #17620 from openshift-cherrypick-robot/cherry-pick…
387006b 
…-17513-to-release-3.7

Automatic merge from submit-queue.

Automated cherry-pick of #17513 on release-3.7

This is an automated cherry-pick of #17513

/assign tnozicka
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
v3.8
Development

Successfully merging this pull request may close these issues.

Statefulset creates and deletes pod repeatedly, race condition or other error?
8 participants
@tnozicka @mfojtik @liggitt @openshift-ci-robot @openshift-bot @openshift-cherrypick-robot @0xmichalis @openshift-merge-robot