Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 55316: Make StatefulSet report an event when recreating failed pod #18060

Conversation

tnozicka
Copy link
Contributor

/assign @mfojtik

@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Jan 11, 2018
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 11, 2018
@tnozicka
Copy link
Contributor Author

tnozicka commented Jan 11, 2018

/cherrypick release-3.8

@tnozicka
Copy link
Contributor Author

tnozicka commented Jan 11, 2018

/cherrypick release-3.7

@mfojtik
Copy link
Contributor

mfojtik commented Jan 11, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, tnozicka

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2018
@tnozicka
Copy link
Contributor Author

/retest

@tnozicka
Copy link
Contributor Author

tnozicka commented Jan 11, 2018

(commented on bad PR)

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 11, 2018

@tnozicka: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/cmd ebbfbd8 link /test cmd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tnozicka
Copy link
Contributor Author

flake: #17787
flake: #18061

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 15739, 18060).

@openshift-cherrypick-robot

@tnozicka: new pull request created: #18065

In response to this:

/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnozicka tnozicka deleted the backport-statefulset-report-event-on-pod-recreate branch January 11, 2018 14:35
@tnozicka
Copy link
Contributor Author

/cherrypick release-3.7

@openshift-cherrypick-robot

@tnozicka: #18060 failed to apply on top of branch "release-3.7":

Using index info to reconstruct a base tree...
M	vendor/k8s.io/kubernetes/pkg/controller/statefulset/stateful_set.go
M	vendor/k8s.io/kubernetes/pkg/controller/statefulset/stateful_set_control.go
M	vendor/k8s.io/kubernetes/pkg/controller/statefulset/stateful_set_control_test.go
M	vendor/k8s.io/kubernetes/pkg/controller/statefulset/stateful_set_test.go
Falling back to patching base and 3-way merge...
Auto-merging vendor/k8s.io/kubernetes/pkg/controller/statefulset/stateful_set_test.go
CONFLICT (content): Merge conflict in vendor/k8s.io/kubernetes/pkg/controller/statefulset/stateful_set_test.go
Auto-merging vendor/k8s.io/kubernetes/pkg/controller/statefulset/stateful_set_control_test.go
CONFLICT (content): Merge conflict in vendor/k8s.io/kubernetes/pkg/controller/statefulset/stateful_set_control_test.go
Auto-merging vendor/k8s.io/kubernetes/pkg/controller/statefulset/stateful_set_control.go
CONFLICT (content): Merge conflict in vendor/k8s.io/kubernetes/pkg/controller/statefulset/stateful_set_control.go
Auto-merging vendor/k8s.io/kubernetes/pkg/controller/statefulset/stateful_set.go
error: Failed to merge in the changes.
Patch failed at 0001 UPSTREAM: 55316: Make StatefulSet report an event when recreating failed pod

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants