Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.7] UPSTREAM: 58572: Automated cherry pick of #58547: Send correct resource version for delete events from watch #18246

Merged
merged 1 commit into from
Jan 24, 2018
Merged

[3.7] UPSTREAM: 58572: Automated cherry pick of #58547: Send correct resource version for delete events from watch #18246

merged 1 commit into from
Jan 24, 2018

Conversation

tnozicka
Copy link
Contributor

Backport of #18233 via kubernetes/kubernetes#58572

/assign @liggitt

@tnozicka tnozicka added kind/bug Categorizes issue or PR as related to a bug. priority/P0 queue/critical-fix priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jan 23, 2018
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 23, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Jan 23, 2018
@liggitt
Copy link
Contributor

liggitt commented Jan 23, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tnozicka

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2018
@liggitt liggitt added this to the 3.7.0 milestone Jan 23, 2018
@tnozicka tnozicka changed the title UPSTREAM: 58572: Automated cherry pick of #58547: Send correct resource version for delete events from watch [3.7] UPSTREAM: 58572: Automated cherry pick of #58547: Send correct resource version for delete events from watch Jan 23, 2018
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@tnozicka
Copy link
Contributor Author

/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 6aeba0c into openshift:release-3.7 Jan 24, 2018
@tnozicka tnozicka deleted the backport-watch-cache-fix-58547-release-3.7 branch January 24, 2018 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. priority/P0 queue/critical-fix size/L Denotes a PR that changes 100-499 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
v3.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tnozicka @liggitt @openshift-ci-robot @openshift-bot @openshift-merge-robot