UPSTREAM: 59506: fix watch on multiple reqs #18514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
openshift-merge-robot
added
the
vendor-update
|
/retest |
1 similar comment
|
/retest |
juanvallejo
force-pushed
the
jvallejo/handle-watch-multiple-reqs
branch
from
81bb300
to
76b38bb
Compare
juanvallejo
force-pushed
the
jvallejo/handle-watch-multiple-reqs
branch
2 times, most recently
from
e0a6d6f
to
d2adfee
Compare
juanvallejo
force-pushed
the
jvallejo/handle-watch-multiple-reqs
branch
from
d2adfee
to
b02c1e6
Compare
juanvallejo
force-pushed
the
jvallejo/handle-watch-multiple-reqs
branch
from
b02c1e6
to
170d39f
Compare
soltysh
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: juanvallejo, soltysh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1537789
oc get <resource> --watchonly supports watching a single resource kind at a time.This check fails if more than one resource
Infois returned.When dealing with large quantities of a single resource kind, or an amount that exceeds the value of
--chunk-size, more than one request is made to the server causing a resourceInfoto be created for each of the requests, ultimately causing the above check to fail even though we are dealing with the same type of resource.This patch modifies that check to take into account the GVKs of all infos returned, and only fail if at least one differs.
cc @deads2k @jeremyeder