Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 60490: Volume deletion should be idempotent #18856

Merged
merged 1 commit into from
Mar 8, 2018

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Mar 6, 2018

Contains tiny piece of #59756 with isAWSErrorVolumeNotFound().

Contains parts of #59756 with isAWSErrorVolumeNotFound() and
describeVolumes() changes.
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 6, 2018
@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 6, 2018

/assign @tsmetana

@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Mar 6, 2018
@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 6, 2018

/cherrypick release-3.9

@openshift-cherrypick-robot

@jsafrane: once the present PR merges, I will cherry-pick it on top of release-3.9 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tsmetana
Copy link
Member

tsmetana commented Mar 6, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2018
@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 6, 2018

/retest

1 similar comment
@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 6, 2018

/retest

@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 6, 2018

/assign @mfojtik
for approval

@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 6, 2018

/retest

1 similar comment
@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 6, 2018

/retest

@mfojtik
Copy link
Contributor

mfojtik commented Mar 6, 2018

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, mfojtik, tsmetana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2018
@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 7, 2018

/retest

@childsb childsb added this to the 3.9.0 milestone Mar 7, 2018
@childsb
Copy link
Contributor

childsb commented Mar 7, 2018

/retest

@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 7, 2018

I manually created 3.9 PR: #18878

Let's see what this thing does:
/cherrypick cancel

@openshift-cherrypick-robot

@jsafrane: once the present PR merges, I will cherry-pick it on top of cancel in a new PR and assign it to you.

In response to this:

I manually created 3.9 PR: #18878

Let's see what this thing does:
/cherrypick cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 7, 2018

I will cherry-pick it on top of cancel in a new PR a

Lol. Anyway, whatever the bot picks, I will close it.

@childsb
Copy link
Contributor

childsb commented Mar 7, 2018

/test extended_conformance_install

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

@jsafrane: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install 9420735 link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@eparis eparis merged commit 89f7b03 into openshift:master Mar 8, 2018
@openshift-cherrypick-robot

@jsafrane: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-3.9 and openshift-cherrypick-robot:cherry-pick-18856-to-release-3.9"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"}

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@jsafrane: cannot checkout cancel: error checking out cancel: exit status 1. output: error: pathspec 'cancel' did not match any file(s) known to git.

In response to this:

I manually created 3.9 PR: #18878

Let's see what this thing does:
/cherrypick cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants