Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 59931: do not delete node in openstack, if those still exist in cloudprovider #19038

Merged
merged 1 commit into from
Mar 21, 2018
Merged

UPSTREAM: 59931: do not delete node in openstack, if those still exist in cloudprovider #19038

merged 1 commit into from
Mar 21, 2018

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Mar 20, 2018 •
edited

kubernetes/kubernetes#59931

xref https://bugzilla.redhat.com/show_bug.cgi?id=1558422

Basically, the fix is to never filter instances by whether they are active or not. Just always return all instances.

@derekwaynecarr

@sjenning sjenning added the kind/bug Categorizes issue or PR as related to a bug. label Mar 20, 2018
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 20, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Mar 20, 2018
@derekwaynecarr
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2018
@sjenning
Copy link
Contributor Author

/test cmd

@sjenning
Copy link
Contributor Author

cmd test passed but seems github didn't get the memo

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 19008, 18727, 19038).

@openshift-merge-robot openshift-merge-robot merged commit 6709c04 into openshift:master Mar 21, 2018
@sjenning sjenning mentioned this pull request Mar 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@deads2k deads2k Awaiting requested review from deads2k

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sjenning @derekwaynecarr @openshift-ci-robot @openshift-bot @openshift-merge-robot