Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 61378: --force only takes effect when --grace-period=0 #19213

Merged
merged 1 commit into from
May 29, 2018
Merged

UPSTREAM: 61378: --force only takes effect when --grace-period=0 #19213

merged 1 commit into from
May 29, 2018

Conversation

juanvallejo
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 4, 2018
@juanvallejo juanvallejo added kind/post-rebase and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 4, 2018
soltysh
soltysh approved these changes Apr 4, 2018
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2018
@soltysh
Copy link
Member

soltysh commented Apr 4, 2018

But
/hold
until the rebase lands.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2018
@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2018
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2018
@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2018
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 26, 2018
@juanvallejo
Copy link
Contributor Author

@soltysh this should be good to go

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 30, 2018
soltysh
soltysh approved these changes Apr 30, 2018
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel
/approve
/lgtm

@soltysh
Copy link
Member

soltysh commented Apr 30, 2018

/retest

@soltysh soltysh added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2018
@juanvallejo
Copy link
Contributor Author

/test cmd

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@juanvallejo juanvallejo force-pushed the jvallejo/pick-upstream-61378 branch from eef3c81 to a7eece5 Compare May 4, 2018 21:52
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 4, 2018
@soltysh
Copy link
Member

soltysh commented May 8, 2018

/retest

soltysh
soltysh approved these changes May 8, 2018
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2018
@soltysh
Copy link
Member

soltysh commented May 8, 2018

/hold

@juanvallejo
Copy link
Contributor Author

/retest

soltysh
soltysh approved these changes May 14, 2018
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2018
@soltysh
Copy link
Member

soltysh commented May 14, 2018

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@soltysh
Copy link
Member

soltysh commented May 18, 2018

/retest

@juanvallejo
Copy link
Contributor Author

@soltysh @stevekuznetsov not sure what the cmd failure is - it appears to be with cmd utils?

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@soltysh
Copy link
Member

soltysh commented May 22, 2018

@juanvallejo it looks like you broke something 😉 I re-run the cmd tests on a VM and got to:

Running test/cmd/idle.sh:22: executing 'oc delete all --all' expecting success...

where it's hanging for the past +10 minutes. Double check what might be causing this, maybe we need to update our tests to set the grace period et all accordingly or we have a bug in upstream as well.

@soltysh
Copy link
Member

soltysh commented May 22, 2018

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2018
@juanvallejo juanvallejo force-pushed the jvallejo/pick-upstream-61378 branch from adb41f8 to 5cc1fda Compare May 23, 2018 20:46
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 23, 2018
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: juanvallejo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 23, 2018
@juanvallejo juanvallejo added the lgtm Indicates that a PR is ready to be merged. label May 24, 2018
@juanvallejo
Copy link
Contributor Author

@soltysh tests passing now

@soltysh
Copy link
Member

soltysh commented May 25, 2018

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2018
@juanvallejo
Copy link
Contributor Author

/retest

3 similar comments
@juanvallejo
Copy link
Contributor Author

/retest

@soltysh
Copy link
Member

soltysh commented May 25, 2018

/retest

@juanvallejo
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 6d89588 into openshift:master May 29, 2018
@juanvallejo juanvallejo deleted the jvallejo/pick-upstream-61378 branch May 29, 2018 18:46
@juanvallejo juanvallejo mentioned this pull request Dec 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@liggitt liggitt Awaiting requested review from liggitt

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/post-rebase lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@juanvallejo @soltysh @openshift-bot @openshift-ci-robot @openshift-merge-robot