Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 62462: Private mount propagation #19364

Merged

Conversation

jsafrane
Copy link
Contributor

Introduce private mount propagation and make it default.

kubernetes/kubernetes#62462

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 16, 2018
@gnufied
Copy link
Member

gnufied commented Apr 16, 2018

cc @liggitt

@jsafrane
Copy link
Contributor Author

/assign @derekwaynecarr
for approval of node changes Please approve kubernetes/kubernetes#62633 too to pick it into 1.10.

@liggitt, please approve the API changes.

@liggitt
Copy link
Contributor

liggitt commented Apr 19, 2018

/lgtm
/hold
hold for upstream 1.10 PR to merge

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2018
@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 19, 2018
@derekwaynecarr
Copy link
Member

/approve

note i just approved the upstream.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsafrane
Copy link
Contributor Author

jsafrane commented May 2, 2018

/hold cancel

It was merged upstream into 1.10.x

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2018
@openshift-merge-robot openshift-merge-robot merged commit b63bc7c into openshift:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants