Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1739601: UPSTREAM: 80491: Changed IsCriticalPod to return true in case of static pods #23576

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Bug 1739601: UPSTREAM: 80491: Changed IsCriticalPod to return true in case of static pods #23576

merged 1 commit into from
Aug 9, 2019

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Aug 8, 2019 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 8, 2019
@mrunalp
Copy link
Member

mrunalp commented Aug 8, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2019
@mfojtik
Copy link
Contributor

mfojtik commented Aug 9, 2019

/retest

@mfojtik
Copy link
Contributor

mfojtik commented Aug 9, 2019

Need a BZ reference after feature freeze :-)

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2019
@sjenning
Copy link
Contributor Author

sjenning commented Aug 9, 2019

I'm fine leaving it until 4.3 unless @derekwaynecarr wants to push it in for 4.2

@derekwaynecarr
Copy link
Member

This should go all the way back to 4.1.

@sjenning sjenning changed the title UPSTREAM: 80491: Changed IsCriticalPod to return true in case of static pods Bug 1739601: UPSTREAM: 80491: Changed IsCriticalPod to return true in case of static pods Aug 9, 2019
@openshift-ci-robot
Copy link

@sjenning: An error was encountered updating the bug to the POST state on the Bugzilla server at https://bugzilla.redhat.com for bug 1739601:

response code 502 not 200
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1739601: UPSTREAM: 80491: Changed IsCriticalPod to return true in case of static pods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning
Copy link
Contributor Author

sjenning commented Aug 9, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 9, 2019
@openshift-ci-robot
Copy link

@sjenning: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning sjenning mentioned this pull request Aug 9, 2019
Merged
@sjenning
Copy link
Contributor Author

sjenning commented Aug 9, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2019
@derekwaynecarr
Copy link
Member

/approve
/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, mrunalp, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [derekwaynecarr,sjenning]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit edc5be3 into openshift:master Aug 9, 2019
@openshift-ci-robot
Copy link

@sjenning: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state.

In response to this:

Bug 1739601: UPSTREAM: 80491: Changed IsCriticalPod to return true in case of static pods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@mrunalp mrunalp

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sjenning @mrunalp @mfojtik @derekwaynecarr @openshift-ci-robot @openshift-bot @openshift-merge-robot