Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-operator/config/openshift/etcd: bump golang 1.12 for 4.3 #5142

Merged
merged 1 commit into from
Oct 23, 2019
Merged

ci-operator/config/openshift/etcd: bump golang 1.12 for 4.3 #5142

merged 1 commit into from
Oct 23, 2019

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Sep 23, 2019 •
edited
Loading

In 4.3 we are bumping the etcd server binary image to v3.3.17 this requires golang 1.12.

Required for openshift/etcd#20

@hexfusion
ci-operator/config/openshift/etcd: bump golang 1.12 for 4.3
2a5facd 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 23, 2019
@hexfusion hexfusion changed the title WIP ci-operator/config/openshift/etcd: bump golang 1.12 for 4.3 ci-operator/config/openshift/etcd: bump golang 1.12 for 4.3 Sep 26, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2019
@hexfusion
Copy link
Contributor Author

/retest

1 similar comment
@hexfusion
Copy link
Contributor Author

/retest

@hexfusion
Copy link
Contributor Author

/refresh

@hexfusion
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

@hexfusion: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/etcd/openshift-4.3/unit 2a5facd link /test pj-rehearse
ci/prow/pj-rehearse 2a5facd link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

retroflexer
retroflexer reviewed Oct 23, 2019
View reviewed changes
Copy link
Contributor

@retroflexer retroflexer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, retroflexer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hexfusion
Copy link
Contributor Author

Unit test fails because of mismatch in code base deps. This will be resolved by the server bump openshift/etcd#20

@openshift-merge-robot openshift-merge-robot merged commit ac67a3e into openshift:master Oct 23, 2019
@openshift-ci-robot
Copy link
Contributor

@hexfusion: Updated the following 2 configmaps:

  • ci-operator-4.3-configs configmap in namespace ci using the following files:
    • key openshift-etcd-openshift-4.3.yaml using file ci-operator/config/openshift/etcd/openshift-etcd-openshift-4.3.yaml
  • ci-operator-4.3-configs configmap in namespace ci-stg using the following files:
    • key openshift-etcd-openshift-4.3.yaml using file ci-operator/config/openshift/etcd/openshift-etcd-openshift-4.3.yaml

In response to this:

In 4.3 we are bumping the etcd server binary image to v3.3.17 this requires golang 1.12.

Required for openshift/etcd#20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion hexfusion deleted the release-4.3-go.1.12 branch October 24, 2019 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retroflexer retroflexer retroflexer left review comments

@hongkailiu hongkailiu Awaiting requested review from hongkailiu

@petr-muller petr-muller Awaiting requested review from petr-muller

Assignees

@retroflexer retroflexer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hexfusion @openshift-ci-robot @retroflexer @openshift-merge-robot