[Draft] OCM-8721 | ci: Tunning the framework for the OCMResource service to use the action methods #2163
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yasun1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
yasun1
changed the title
…se the action methods
|
@yasun1: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2163 +/- ##
==========================================
- Coverage 26.67% 26.51% -0.17%
==========================================
Files 152 154 +2
Lines 21403 21720 +317
==========================================
+ Hits 5710 5759 +49
- Misses 15269 15534 +265
- Partials 424 427 +3 ☔ View full report in Codecov by Sentry. |
|
|
||
| func (b *breakglasscredentialService) CleanResources(clusterID string) (errors []error) { | ||
| if b.created[clusterID] { | ||
| Logger.Infof("Remove remaining break-glass-credentials") | ||
| _, err := b.DeleteBreakGlassCredential(clusterID) | ||
| _, err := b.Revoke().Help().Run() |
There was a problem hiding this comment.
This is an incorrect replacement. It should be b.Revoke().Parameters(clusterID).Run()
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…he action methods