OCM-9613 | feat: Allow billing account update via the cluster edit command #2258

cristianoveiga · 2024-07-16T17:38:38Z

No description provided.

openshift-ci · 2024-07-16T17:38:58Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cristianoveiga
Once this PR has been reviewed and has the lgtm label, please assign oriadler for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

codecov · 2024-07-16T18:21:12Z

Codecov Report

Attention: Patch coverage is 8.24742% with 89 lines in your changes missing coverage. Please review.

Project coverage is 29.20%. Comparing base (af0e365) to head (14b5d77).

Files	Patch %	Lines
cmd/edit/cluster/cmd.go	11.32%	47 Missing ⚠️
pkg/ocm/billing.go	0.00%	30 Missing ⚠️
cmd/create/cluster/cmd.go	28.57%	5 Missing ⚠️
pkg/interactive/interactive.go	0.00%	4 Missing ⚠️
pkg/ocm/clusters.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2258      +/-   ##
==========================================
- Coverage   29.41%   29.20%   -0.21%     
==========================================
  Files         161      161              
  Lines       22311    22395      +84     
==========================================
- Hits         6563     6541      -22     
- Misses      15206    15312     +106     
  Partials      542      542

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ciaranRoche

This LGTM, just to confirm is there any blocker keeping this in draft?

cristianoveiga · 2024-07-17T13:30:04Z

This LGTM, just to confirm is there any blocker keeping this in draft?

Thanks @ciaranRoche . We have been asked to review this change with the UX team.

I will resume the work on this whenever we get their input.

ciaranRoche · 2024-07-17T15:09:53Z

@cristianoveiga one worry is this will get out of date, and result in more work on your end to keep up to date. Do we have an idea of how long it will take for UX review

cristianoveiga · 2024-07-17T15:22:11Z

@cristianoveiga one worry is this will get out of date, and result in more work on your end to keep up to date. Do we have an idea of how long it will take for UX review

Indeed - I share the same concern.

I'm trying to identify an UX contact to get this information. I will keep you posted.

cmd/edit/cluster/cmd.go

abhgupta · 2024-07-17T19:15:50Z

cmd/edit/cluster/cmd.go

+			r.Reporter.Infof(
+				"The selected AWS billing account is a different account than your AWS infrastructure account." +
+					"The AWS billing account will be charged for subscription usage. " +
+					"The AWS infrastructure account will be used for managing the cluster.",


No space between the first and second sentence.
This needs rewording - "The AWS infrastructure account will be used for managing the cluster."

Can be reworded as "The AWS infrastructure account contains the ROSA infrastructure".

abhgupta · 2024-07-17T19:20:26Z

Additional review comments that I could not figure out where to comment in the file changes.

The "Billing Account" prompt should be "Update billing account"
Instead of "default", we should highlight the AWS account as the "current" billing account that is shown within parenthesis.
The text message once the user switches their AWS billing account should be entirely rewritten.

cristianoveiga · 2024-07-17T20:27:38Z

Additional review comments that I could not figure out where to comment in the file changes.

The "Billing Account" prompt should be "Update billing account"

Instead of "default", we should highlight the AWS account as the "current" billing account that is shown within parenthesis.

The text message once the user switches their AWS billing account should be entirely rewritten.

I've addressed items 1 and 2 above.

cmd/create/cluster/cmd.go

lnagendr · 2024-07-31T14:34:24Z

This LGTM. I don't have any additional comments.

cristianoveiga · 2024-07-31T15:21:15Z

/retest

cristianoveiga · 2024-07-31T15:44:24Z

/retest

cristianoveiga · 2024-07-31T16:21:00Z

This LGTM, just to confirm is there any blocker keeping this in draft?

Thanks @ciaranRoche . We have been asked to review this change with the UX team.

I will resume the work on this whenever we get their input.

Hi @ciaranRoche , I've addressed the PR comments and we have received green light from @lnagendr .

Can you please take another look at this and merge it if you don't have any additional comments?

cmd/create/cluster/cmd.go

jseseCCS · 2024-07-31T23:19:52Z

cmd/create/cluster/cmd.go

 							"The AWS billing account will be charged for subscription usage. " +
-							"The AWS infrastructure account will be used for managing the cluster.",
+							"The AWS infrastructure account contains the ROSA infrastructure.",


the account contains the infrastructure? or does the thing that the account is for contain the infrastructure?

@jseseCCS it's the latter.

jseseCCS · 2024-07-31T23:21:25Z

cmd/edit/cluster/cmd.go

+		&args.billingAccount,
+		"billing-account",
+		"",
+		"Account used for billing subscriptions purchased via the AWS console for ROSA",


jseseCCS · 2024-07-31T23:28:44Z

hey, guys!

a general note about error messages: Whenever possible, tell users why the problem occurred and how to fix or diagnose the problem.

jseseCCS · 2024-07-31T23:29:56Z

let me know if i can be of any more help. I'm just a ping/@ away.

cristianoveiga · 2024-08-01T17:45:22Z

let me know if i can be of any more help. I'm just a ping/@ away.

Thanks!

cristianoveiga · 2024-08-27T16:14:06Z

/retest

cristianoveiga · 2024-08-28T13:24:34Z

/retest

…mmand

openshift-ci · 2024-08-28T14:24:41Z

@cristianoveiga: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci bot requested review from den-rgb and robpblake July 16, 2024 17:38

cristianoveiga force-pushed the ocm-9613-allow-billing-account-update branch from 7e9899c to fae7327 Compare July 16, 2024 18:05

cristianoveiga marked this pull request as draft July 16, 2024 18:35

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2024

ciaranRoche reviewed Jul 17, 2024

View reviewed changes

abhgupta reviewed Jul 17, 2024

View reviewed changes

jseseCCS reviewed Jul 25, 2024

View reviewed changes

cmd/create/cluster/cmd.go Show resolved Hide resolved

cristianoveiga force-pushed the ocm-9613-allow-billing-account-update branch 2 times, most recently from 123955d to 8ff1a07 Compare July 25, 2024 15:57

cristianoveiga marked this pull request as ready for review July 31, 2024 14:36

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2024

openshift-ci bot requested review from ciaranRoche and hunterkepley July 31, 2024 14:46

cristianoveiga force-pushed the ocm-9613-allow-billing-account-update branch 2 times, most recently from 5281a3b to 07d136b Compare July 31, 2024 15:03

cristianoveiga force-pushed the ocm-9613-allow-billing-account-update branch from 07d136b to 7e647c5 Compare July 31, 2024 15:35

cristianoveiga force-pushed the ocm-9613-allow-billing-account-update branch from 7e647c5 to bb96300 Compare July 31, 2024 15:55

jseseCCS reviewed Jul 31, 2024

View reviewed changes

cmd/create/cluster/cmd.go Outdated Show resolved Hide resolved

jseseCCS reviewed Jul 31, 2024

View reviewed changes

cmd/create/cluster/cmd.go Outdated Show resolved Hide resolved

jseseCCS reviewed Jul 31, 2024

View reviewed changes

cristianoveiga force-pushed the ocm-9613-allow-billing-account-update branch from bb96300 to b2ea93a Compare August 27, 2024 15:04

cristianoveiga force-pushed the ocm-9613-allow-billing-account-update branch from b2ea93a to 75cc8d5 Compare August 28, 2024 13:29

OCM-9613 | feat: Allow billing account update via the cluster edit co…

14b5d77

…mmand

cristianoveiga force-pushed the ocm-9613-allow-billing-account-update branch from 75cc8d5 to 14b5d77 Compare August 28, 2024 14:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCM-9613 | feat: Allow billing account update via the cluster edit command #2258

OCM-9613 | feat: Allow billing account update via the cluster edit command #2258

cristianoveiga commented Jul 16, 2024

openshift-ci bot commented Jul 16, 2024

codecov bot commented Jul 16, 2024 •

edited

Loading

ciaranRoche left a comment

cristianoveiga commented Jul 17, 2024

ciaranRoche commented Jul 17, 2024

cristianoveiga commented Jul 17, 2024

abhgupta Jul 17, 2024

lnagendr Jul 24, 2024

abhgupta commented Jul 17, 2024

cristianoveiga commented Jul 17, 2024

lnagendr commented Jul 31, 2024

cristianoveiga commented Jul 31, 2024

cristianoveiga commented Jul 31, 2024

cristianoveiga commented Jul 31, 2024

jseseCCS Jul 31, 2024

lnagendr Aug 1, 2024

jseseCCS Jul 31, 2024

lnagendr Aug 1, 2024

jseseCCS commented Jul 31, 2024

jseseCCS commented Jul 31, 2024

cristianoveiga commented Aug 1, 2024

cristianoveiga commented Aug 27, 2024

cristianoveiga commented Aug 28, 2024

openshift-ci bot commented Aug 28, 2024

OCM-9613 | feat: Allow billing account update via the cluster edit command #2258

Are you sure you want to change the base?

OCM-9613 | feat: Allow billing account update via the cluster edit command #2258

Conversation

cristianoveiga commented Jul 16, 2024

openshift-ci bot commented Jul 16, 2024

codecov bot commented Jul 16, 2024 • edited Loading

Codecov Report

ciaranRoche left a comment

Choose a reason for hiding this comment

cristianoveiga commented Jul 17, 2024

ciaranRoche commented Jul 17, 2024

cristianoveiga commented Jul 17, 2024

abhgupta Jul 17, 2024

Choose a reason for hiding this comment

lnagendr Jul 24, 2024

Choose a reason for hiding this comment

abhgupta commented Jul 17, 2024

cristianoveiga commented Jul 17, 2024

lnagendr commented Jul 31, 2024

cristianoveiga commented Jul 31, 2024

cristianoveiga commented Jul 31, 2024

cristianoveiga commented Jul 31, 2024

jseseCCS Jul 31, 2024

Choose a reason for hiding this comment

lnagendr Aug 1, 2024

Choose a reason for hiding this comment

jseseCCS Jul 31, 2024

Choose a reason for hiding this comment

lnagendr Aug 1, 2024

Choose a reason for hiding this comment

jseseCCS commented Jul 31, 2024

jseseCCS commented Jul 31, 2024

cristianoveiga commented Aug 1, 2024

cristianoveiga commented Aug 27, 2024

cristianoveiga commented Aug 28, 2024

openshift-ci bot commented Aug 28, 2024

codecov bot commented Jul 16, 2024 •

edited

Loading