Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-9995 | feat: Adding rosa quickstart POC #2380

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

den-rgb
Copy link
Contributor

@den-rgb den-rgb commented Aug 22, 2024

to run the command ->

rosa bootstrap rosa-quickstart-default-vpc --param Name=rosa-quickstart-default --param VpcCidr=10.0.0.0/16 --param Region=us-west-2 --param AvailabilityZonesCount=2 --param Tags=key1=value1,key2=value2

Whats New

  • Added region
  • added params
  • different templates will be called depending on the first arg passed in eg:rosa-quickstart-default-vpc
  • Modified Tags handling + added default tags
  • Account + Org validation
  • vpc template no longer requires s3 bucket hosting
  • no longer creates nested stacks

@den-rgb den-rgb marked this pull request as draft August 22, 2024 11:19
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 22, 2024
Copy link
Contributor

openshift-ci bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: den-rgb
Once this PR has been reviewed and has the lgtm label, please assign xueli181114 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Aug 22, 2024

@den-rgb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/coverage a5f514d link true /test coverage
ci/prow/test a5f514d link true /test test
ci/prow/lint a5f514d link true /test lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

cmd/create/quick-start-cluster/cmd.go Outdated Show resolved Hide resolved
cmd/create/quick-start-cluster/cmd.go Outdated Show resolved Hide resolved
cmd/create/quick-start-cluster/vpc.yaml Outdated Show resolved Hide resolved
cmd/create/quick-start-cluster/cmd.go Outdated Show resolved Hide resolved
@den-rgb den-rgb force-pushed the OCM-9995 branch 6 times, most recently from d5da571 to 7608ca9 Compare September 10, 2024 15:46
cmd/bootstrap/cmd.go Outdated Show resolved Hide resolved
cmd/bootstrap/cmd.go Outdated Show resolved Hide resolved
cmd/bootstrap/cmd.go Outdated Show resolved Hide resolved
cmd/bootstrap/cmd.go Outdated Show resolved Hide resolved
cmd/bootstrap/cmd.go Outdated Show resolved Hide resolved
@den-rgb den-rgb force-pushed the OCM-9995 branch 3 times, most recently from d07d9c2 to ca62ae0 Compare September 16, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants