OCM-11019 | fix: Do not accept clusterID for thumbprint if programmatic #2443
Conversation
|
@hunterkepley: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/cherrypick release_1.2.45 |
|
@davidleerh: once the present PR merges, I will cherry-pick it on top of release_1.2.45 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
davidleerh
added
approved
|
@davidleerh: new pull request created: #2444 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidleerh, hunterkepley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidleerh, hunterkepley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2443 +/- ##
=======================================
Coverage 29.37% 29.37%
=======================================
Files 161 161
Lines 22365 22365
=======================================
Hits 6569 6569
Misses 15251 15251
Partials 545 545 ☔ View full report in Codecov by Sentry. |
https://issues.redhat.com/browse/OCM-11019
Works with:
Issue was that, when creating a cluster and providing an oidc config id, it would send both, causing a failure
There was a secondary issue, where when creating an HCP cluster, it does not technically exist at the time of creating a provider, which differs from classic. This was fixed by only supplying the OIDC ID in this situation. If you only supply cluster ID, it will fail due to non-existent HCP cluster