Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-11297 | test: automated cases id:38810 #2483

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

msmigiel-rh
Copy link
Contributor

ansible-2.9) msmigiel@msmigiel-thinkpadp1gen5:~/Documents/rosa$ ginkgo run -focus 38810 tests/e2e
Running Suite: ROSA CLI e2e tests suite - /home/msmigiel/Documents/rosa/tests/e2e
=================================================================================
Random Seed: 1726839612

Will run 1 of 226 specs
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS

Ran 1 of 226 Specs in 10.556 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 225 Skipped
PASS

Ginkgo ran 1 suite in 14.278910587s
Test Suite Passed

Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: msmigiel-rh
Once this PR has been reviewed and has the lgtm label, please assign yasun1 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mgahagan73
Copy link

I think we should pass the versions as variables rather than hard coded strings. Over time versions may get added/removed from the list of supported versions so the test may need to be updated in the future. If we use variables it makes the test a little easier to maintain as we only have to change the version values in one place.

@msmigiel-rh
Copy link
Contributor Author

Thank you, I was thinking the same thing after discussing with Ohad. I will look into doing this.

Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

@msmigiel-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.45%. Comparing base (3a9ac1f) to head (5340e82).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2483      +/-   ##
==========================================
+ Coverage   29.35%   29.45%   +0.09%     
==========================================
  Files         161      161              
  Lines       22364    22397      +33     
==========================================
+ Hits         6566     6597      +31     
- Misses      15253    15256       +3     
+ Partials      545      544       -1     
Flag Coverage Δ
29.45% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants