-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-11297 | test: automated cases id:38810 #2483
base: master
Are you sure you want to change the base?
Conversation
msmigiel-rh
commented
Sep 20, 2024
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: msmigiel-rh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think we should pass the versions as variables rather than hard coded strings. Over time versions may get added/removed from the list of supported versions so the test may need to be updated in the future. If we use variables it makes the test a little easier to maintain as we only have to change the version values in one place. |
Thank you, I was thinking the same thing after discussing with Ohad. I will look into doing this. |
@msmigiel-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2483 +/- ##
==========================================
+ Coverage 29.35% 29.45% +0.09%
==========================================
Files 161 161
Lines 22364 22397 +33
==========================================
+ Hits 6566 6597 +31
- Misses 15253 15256 +3
+ Partials 545 544 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |