Merge change to master #20
Conversation
Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
* Remove admin priviliged rights: `anyuid` and `cluster-admin`. * Add uidwrapper to set a fixed username By default openshift runs as random user which get git < 2.0 confused and fail its operations. Use a wrapper around some containers (git-init/creds-init) to set a fixed uid. https://docs.okd.io/latest/creating_images/guidelines.html#openshift-specific-guidelines * Use some trickery for envsubst Envsubst is a stuborn whiny child who wants to subst our variables even tho we don't want to modify those. Since there is no way to exclude some variables, we have our beautiful DOLLAR string replacing the dollar and we sed 's//' it after that envsubst have done its dirty work. Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
openshift-ci-robot
added
size/M
|
/lgtm |
|
@chmouel: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@chmouel: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.