Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1918792: pkg/rules/proxy: fix hotlooping when receiving client errors #47

Merged
merged 1 commit into from
Jan 27, 2021

Commits on Jan 21, 2021

  1. pkg/rules/proxy: fix hotlooping when receiving client errors

    Currently, if we receive an error from the underlying client stream,
    we continue with trying to receive additional data.
    This causes a hotloop as we will receive the same error again.
    This fixes it by returning in the error case and adds a unit test for the proxy logic.
    
    Fixes thanos-io#3717
    
    Signed-off-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>
    s-urbaniak committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    06c570f View commit details
    Browse the repository at this point in the history