Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix couldCallSwipeEvent from returning false when not all props are provided #97

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fix couldCallSwipeEvent from returning false when not all props are provided #97

merged 1 commit into from
Mar 28, 2024

Conversation

jaredbothwell
Copy link

Fixes #96

onSwipe, onSwipeUp, onSwipeDown, onSwipeLeft, and onSwipeRight are all optional props for ReactNativeZoomableViewWithGestures but couldCallSwipeEvent() returns false when one of these props is not provided. This PR allows couldCallSwipeEvent to return true if at least one of these props are provided.

elliottkember
elliottkember approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@elliottkember elliottkember left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliottkember elliottkember merged commit aae2434 into openspacelabs:master Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliottkember elliottkember elliottkember approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_couldCallSwipeEvent() returns false when not all props are provided
2 participants
@jaredbothwell @elliottkember