-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preset for leisure=bathing_place (#1217) #1274
base: main
Are you sure you want to change the base?
Conversation
Shouldn't the preset also be allowed for areas? Some are mapped as an area, e.g. https://www.openstreetmap.org/way/1203484522, https://www.openstreetmap.org/way/56313252 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
I did a quick review and write down the questions I would like to check out during a proper review. Maybe someone can help with answers.
It would also be great to have a few screenshots on the search so we can see that there are no weird results where users would now pick a wrong answer due to the new preset.
"Bathing spot", | ||
"Dip spot", | ||
"Dipping spot", | ||
"Swim spot", | ||
"Swimming spot", | ||
"Wild swimming spot" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you double check the convention of aliases
in other presets. I think they are either all lower case or "Camel Case".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Camel Case! Will update
"Swimming spot", | ||
"Wild swimming spot" | ||
], | ||
"icon": "fas-water-ladder", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ladder" does not sound ideal for a place that is often unofficial and will likely not have a ladder. What would be other options?
Do we use ladder for other presets as well? (Might this cause confusion?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! So
public_bath
uses maki-water which is just a drop of water, and the same icon is used by a lot of other water-related features e.g. lake and spring, so probably a poor choicebeach_resort
uses fas-umbrella-beach which is probably worse because it doesn't even show waterswimming_area
uses fas-swimmer which I can't find on the FAS website but looks identical to person-swimming- I suggested fas-water-ladder because I was under the impression that it was not used in this project (the search didn't return anything) but I have since realised that it's actually being used in the swimming pool preset where it's called fas-swimming-pool!
"Swimming spot", | ||
"Wild swimming spot" | ||
], | ||
"icon": "fas-water-ladder", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ladder" does not sound ideal for a place that is often unofficial and will likely not have a ladder. What would be other options?
Do we use ladder for other presets as well? (Might this cause confusion?)
"icon": "fas-water-ladder", | ||
"fields": [ | ||
"name", | ||
"access_simple", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the wikis recommendations or conventions on how to tag "this is an unofficial vs. official (signed) place"? Is it access or supervised? Maybe move supervised up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot. That would be informal
which I forgot to add to the preset.
"opening_hours", | ||
"operator", | ||
"fee", | ||
"payment_multi_fee", | ||
"charge_fee", | ||
"supervised", | ||
"lifeguard_check", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this tag used for kind of official places as well? Or do they become something else once they are paid and supervised?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would normally make it an amenity=public_bath
or possibly a leisure=beach_resort
. So although a few dozen bathing_place
s have fee
, opening_hours
, supervised
and/or lifeguard
tags, the answer (key) is almost always no
and 24/7
. That's why I put it in moreFields
, not in fields
. But I am not very familiar with the conventions of id-tagging-schema - let me know if this means that, for example, it should not be in the preset at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think about it this way…
- add fields/moreFields that are already used a lot in the data
- add fields/moreFields that are very helpful to have and documented/"in use"
- don't add fields/moreFields that we don't want new Users to add
So in this case the question seems to be if we want to give visibility to data that is present but maybe wrong because it should be a different primary tag. I think we should not add those fields. Experienced users will see the data regardless. But less experienced users will not add "false" data. Experienced users can change the preset and then the data will be visible.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, did not catch that this was not triggered yet. The setup is that for first contributors, someone with permissions has to trigger the checks. On Action will be to create the preview and comment on the PR with the link. That will happen in a few minutes. For your next PR, this will run automatically. |
🍱 You can preview the tagging presets of this pull request here. |
Description, Motivation & Context
(source)
A bathing place (German: Badestelle, Swedish: badplats) is a designated spot where you can swim or 'bathe'. In Europe these are often signposted by the local authority, as these are the spots where swimming is officially allowed or encouraged, water quality monitored, etc.
The English translation 'bathing place' is a bit awkward but I think the concept of a designated or widely known spot for outdoor swimming is a global one. I have tried to suggest a few synonyms.
leisure=bathing_place
has existed for many years as a tag, but bathing places have also been mapped using various other tags that don't really fit e.g.leisure=water_park
and I think that's partly because a preset forleisure=bathing_place
isn't more widely available.The tagging scheme does already contain a preset for
leisure=swimming_area
, for areas only. In a recent community forum discussion it was agreed thatleisure=swimming_area
is for the part of the water that has been roped off or otherwise clearly designated for swimming, whereas aleisure=bathing_place
doesn't usually have a clearly defined boundary so it will usually be mapped as a node. It's a POI - in some languages, people say the equivalent of "let's meet at the bathing place".Related issues
Closes #1217.
Links and data
Relevant OSM Wiki links:
leisure=bathing_place
Relevant tag usage stats: