-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add leisure=schoolyard #134
base: main
Are you sure you want to change the base?
Conversation
Add schoolyard preset
Is this repo maintained? |
It’s not abandoned, it’s just waiting for Quincy’s replacement to come along. Or somebody could adopt it. But nothing here will be available to iD until iD has a new maintainer so there’s no hurry to merge here. |
Ah shame, if I had a better knowledge of JavaScript I would have applied to the position. |
Projects shouldn't really depend on a single person to be the maintainer. Is anyone from the openstreetmap org willing to work with me to transfer this repo over to either the osmlab or ideditor organization so that the community can maintain it? I could just move the code, but it's nicer to have the whole repo transferred so we can keep the issues and history. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see much traction on the usage of this tag, however wiki clearly states that this tagging is appropriate for mapping schoolyards and this comment does have a good point,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the usage of this tag has increased quite a bit over the past year or so, it still is orders of magnitudes lower than what would expect from a really well established tag. Given the the tag also didn't undergo a proposal stage as far as I can see, I think its best to not yet merge this at the moment.
Also, the playground icon is really not ideal, since the schoolyard is supposed to be a mapped alongside a school's actual playground.
“Orders of magnitude”, plural, might be overstating it a bit. 🙂 It’s pretty unlikely that the community will ever find the same order of magnitude of schoolyards as playgrounds (which are two orders of magnitude more common in the database). A correctly micromapped schoolground might have just one
Agreed, the existing swing icon would be misleading for this preset. I’m unsure what would be a better preset icon though. These things are characterized by being quite plain, often little more than a big paved area. Maybe something like the existing Pedestrian Area icon, but with a figure of a running child inside instead of a generic walking person? Or playing with a jumprope (skipping rope)? |
I was comparing it to The main problem I have with accepting this relatively new tag (again, compared to its school related map feature siblings) is that it didn't undergo a proposal stage is that it could always be the case that it turns out to be "problematic". Maybe the FWIW, JOSM also doesn't have a preset for |
9d3204d
to
49f529e
Compare
I think it is perfectly fine for this tag to be far less used, it is kind of micromapping - in the same way as typical school will not have footway going to mapped or trees next to it will not be mapped what you think about making a thread at community forums to check is there any real opposition to this tag or concerns? And accept is as valid if there are no real complaints |
Something like a forum thread would be the minimum to be expected for a tag that's meant to be used in the micromapping of a thing as prominent as schools. See also our new general guidelines. @TurnrDev I know it has been a long time since you opened this PR. Are you still interested in bringing this effort forward? If yes, it would be very much appreciated if you could start a discussion about this and after a suitable time report back here with a summary. 🙏 |
I appreciate I was the one who initially created this PR, and thus it makes sense for me to lead that discussion, however, leading discussions is not really one of my strengths and my investment to this is not that high. (I'm always that person with the mic off and camera off in any meeting above 3 people.) I'm going to kindly decline, but with that said, I'm going to leave the PR open and am happy to make any changes necessary if someone else does pick up that discussion. |
hmm, I think I can create thread like this om community forums: title: leisure=schoolyard - is it a good tag worth promoting? body: There is https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dschoolyard tag that seems reasonable to me. But, partially because it is kind of micromapping it is used relatively rarely. At #134 it was proposed to add it to presets but maintainers are worried that there are some possible problems with it as it is relatively rare and have not went through proposal process. Are you aware about any issues with this tag that should result in it not being promoted by presets? Or is it a fine tag worth supporting for example in iD presets? |
@TurnrDev fair enough. That's totally ok. @matkoniecz thanks for the offer to take this over! 👍 If you want, you can quote my concerns from my comment above: #134 (comment) |
Add schoolyard preset based on wiki page for leisure=schoolyard.
Icon might need changing but I don't know
Requirement for gravitystorm/openstreetmap-carto#4324