Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leisure=schoolyard #134

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TurnrDev
Copy link

@TurnrDev TurnrDev commented Feb 20, 2021

Add schoolyard preset based on wiki page for leisure=schoolyard.

Icon might need changing but I don't know

Requirement for gravitystorm/openstreetmap-carto#4324

Add schoolyard preset
@TurnrDev
Copy link
Author

Is this repo maintained?

@tordans
Copy link
Collaborator

tordans commented May 28, 2021

@bryceco
Copy link

bryceco commented May 28, 2021

It’s not abandoned, it’s just waiting for Quincy’s replacement to come along. Or somebody could adopt it. But nothing here will be available to iD until iD has a new maintainer so there’s no hurry to merge here.

@TurnrDev
Copy link
Author

https://twitter.com/osm_tech/status/1389546368197349376?s=21

Ah shame, if I had a better knowledge of JavaScript I would have applied to the position.

@bhousel
Copy link
Member

bhousel commented May 28, 2021

It’s not abandoned, it’s just waiting for Quincy’s replacement to come along. Or somebody could adopt it. But nothing here will be available to iD until iD has a new maintainer so there’s no hurry to merge here.

Projects shouldn't really depend on a single person to be the maintainer. Is anyone from the openstreetmap org willing to work with me to transfer this repo over to either the osmlab or ideditor organization so that the community can maintain it? I could just move the code, but it's nicer to have the whole repo transferred so we can keep the issues and history.

mbrzakovic
mbrzakovic previously approved these changes Nov 10, 2021
Copy link
Collaborator

@mbrzakovic mbrzakovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see much traction on the usage of this tag, however wiki clearly states that this tagging is appropriate for mapping schoolyards and this comment does have a good point,

@tyrasd tyrasd added the waitfor-consensus there seems to be no clear consensus on this in the osm communtiy; this has to wait label Dec 14, 2021
Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the usage of this tag has increased quite a bit over the past year or so, it still is orders of magnitudes lower than what would expect from a really well established tag. Given the the tag also didn't undergo a proposal stage as far as I can see, I think its best to not yet merge this at the moment.

Also, the playground icon is really not ideal, since the schoolyard is supposed to be a mapped alongside a school's actual playground.

@tyrasd tyrasd dismissed mbrzakovic’s stale review December 14, 2021 18:00

not approved tag, low usage

@1ec5
Copy link
Contributor

1ec5 commented Dec 16, 2021

it still is orders of magnitudes lower than what would expect from a really well established tag

“Orders of magnitude”, plural, might be overstating it a bit. 🙂 It’s pretty unlikely that the community will ever find the same order of magnitude of schoolyards as playgrounds (which are two orders of magnitude more common in the database). A correctly micromapped schoolground might have just one leisure=schoolyard but a dozen leisure=playgrounds corresponding to the mulched area around each playground set.

Also, the playground icon is really not ideal, since the schoolyard is supposed to be a mapped alongside a school's actual playground.

Agreed, the existing swing icon would be misleading for this preset. I’m unsure what would be a better preset icon though. These things are characterized by being quite plain, often little more than a big paved area. Maybe something like the existing Pedestrian Area icon, but with a figure of a running child inside instead of a generic walking person? Or playing with a jumprope (skipping rope)?

@tyrasd
Copy link
Member

tyrasd commented Dec 16, 2021

I was comparing it to building=school, which one could consider to be around at the same micromapping-level (going with the example diagram given in the wiki for leisure=schoolyard), and I assumed that most schools in reality consist of a similar number yards as of buildings. But perhaps its that's a bit "unfair" to the poor non-building tag. 😉

The main problem I have with accepting this relatively new tag (again, compared to its school related map feature siblings) is that it didn't undergo a proposal stage is that it could always be the case that it turns out to be "problematic". Maybe the leisure is suboptimal, and something like landuse=schoolyard would have been the better choice. Or maybe these places would be better mapped as a special kind of playground (e.g. leisure=playground + playground=schoolyard) or even as a pedestrian area (thinking about it… something like highway=pedestrian + area=yes + pedestrian=schoolyard + access=… would even work to bad from a routing point of view). I just don't know. 🤷

FWIW, JOSM also doesn't have a preset for leisure=schoolyard at the moment.

@matkoniecz
Copy link
Contributor

The main problem I have with accepting this relatively new tag (again, compared to its school related map feature siblings) is that it didn't undergo a proposal stage is that it could always be the case that it turns out to be "problematic". Maybe the leisure is suboptimal, and something like landuse=schoolyard would have been the better choice. Or maybe these places would be better mapped as a special kind of playground (e.g. leisure=playground + playground=schoolyard) or even as a pedestrian area (thinking about it… something like highway=pedestrian + area=yes + pedestrian=schoolyard + access=… would even work to bad from a routing point of view). I just don't know. 🤷

I think it is perfectly fine for this tag to be far less used, it is kind of micromapping - in the same way as typical school will not have footway going to mapped or trees next to it will not be mapped

what you think about making a thread at community forums to check is there any real opposition to this tag or concerns? And accept is as valid if there are no real complaints

@tyrasd
Copy link
Member

tyrasd commented Aug 8, 2024

what you think about making a thread at community forums to check is there any real opposition to this tag or concerns? And accept is as valid if there are no real complaints

Something like a forum thread would be the minimum to be expected for a tag that's meant to be used in the micromapping of a thing as prominent as schools.

See also our new general guidelines.

@TurnrDev I know it has been a long time since you opened this PR. Are you still interested in bringing this effort forward? If yes, it would be very much appreciated if you could start a discussion about this and after a suitable time report back here with a summary. 🙏

@TurnrDev
Copy link
Author

TurnrDev commented Aug 8, 2024

I appreciate I was the one who initially created this PR, and thus it makes sense for me to lead that discussion, however, leading discussions is not really one of my strengths and my investment to this is not that high. (I'm always that person with the mic off and camera off in any meeting above 3 people.) I'm going to kindly decline, but with that said, I'm going to leave the PR open and am happy to make any changes necessary if someone else does pick up that discussion.

@matkoniecz
Copy link
Contributor

hmm, I think I can create thread like this om community forums:

title: leisure=schoolyard - is it a good tag worth promoting?

body:

There is https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dschoolyard tag that seems reasonable to me. But, partially because it is kind of micromapping it is used relatively rarely.

At #134 it was proposed to add it to presets but maintainers are worried that there are some possible problems with it as it is relatively rare and have not went through proposal process.

Are you aware about any issues with this tag that should result in it not being promoted by presets? Or is it a fine tag worth supporting for example in iD presets?

@tyrasd
Copy link
Member

tyrasd commented Aug 8, 2024

@TurnrDev fair enough. That's totally ok.

@matkoniecz thanks for the offer to take this over! 👍 If you want, you can quote my concerns from my comment above: #134 (comment)

@matkoniecz
Copy link
Contributor

posted on https://community.openstreetmap.org/t/leisure-schoolyard-is-it-a-good-tag-worth-promoting/117170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waitfor-consensus there seems to be no clear consensus on this in the osm communtiy; this has to wait
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants